StatCan / kubeflow-containers-desktop

Experimental containers to be used with Kubeflow for a Desktop experience
Other
1 stars 2 forks source link

feat(novnc): metaKey copy+paste #20

Closed frazs closed 4 years ago

frazs commented 4 years ago

Attempts to address https://github.com/StatCan/kubeflow-containers/issues/56 for Mac keyboard users, although I cannot test this. See https://github.com/StatCan/kubeflow-containers/issues/56#issuecomment-648234508

frazs commented 4 years ago

Requesting review from anyone on MacOS with a Mac keyboard:

  1. In kubeflow, create a Notebook Server based on the custom image k8scc01covidacr.azurecr.io/remote-desktop-base:testmeta. Connect to it, go to Open Tools in the top right corner, and enter VNC.
  2. In the VNC session, create and open a text file. Try to use Command-c and Command-v to copy text between the text file in the VNC session and your computer. Try this with different browsers. Note that Firefox presently only supports writing to, and not reading from, your local clipboard. Note that Chrome might map metaKey to Control instead of Command (to be confirmed: try Control+c and Control+v).
  3. If nothing in (2) works, go to Applications (top left corner) -> Settings -> Keyboard -> 'Layout' tab. Uncheck System defaults and select something that looks right, maybe MacBook/MacBook Pro or MacBook/MacBook Pro (intl.). Under Change layout option, try Right Alt, Left Alt, or Alt.

Let me know if anything works (and if so what specifically).

This issue may warrant being taken over by someone with a Mac keyboard, unless there is any way I could emulate one.

saffaalvi commented 4 years ago

On Chrome, you can copy from the VNC using Control+c and paste it onto your computer using Command+v. You can also copy from your computer using Command+c and paste it onto the VNC using Control+v.

On Firefox, you can only copy from the VNC using Control+c and paste it onto your computer using Command+v.

On Safari, I couldn’t find a way to copy/paste from the VNC to the computer and vice-versa even after changing the Keyboard Layout settings like mentioned above.

chritter commented 4 years ago

@frazs @saffaalvi Thank you for testing the copy/paste functionality. My team will use Chrome as the copy/paste functionality works on our Macs.