search

StatCan / kubeflow-containers-desktop

Experimental containers to be used with Kubeflow for a Desktop experience
Other
1 stars 2 forks source link

feat(landing_page): First draft #30

Closed frazs closed 4 years ago

frazs commented 4 years ago

First draft of the landing page. The functionality and general concept is there, and if desired I can add on some relatively simple things such as SVG icons, but I am not much of a front end developer so this may warrant being passed up to somebody in UI.

Addresses https://github.com/StatCan/kubeflow-containers/issues/38

frazs commented 4 years ago

https://htmlpreview.github.io/?https://github.com/StatCan/kubeflow-containers-desktop/blob/landingpage/base/resources/landing_page/index.html

frazs commented 4 years ago

Threw in a quick go at icons, which works great locally but is completely messed in that html preview, so I'm going to take a look into that.

frazs commented 4 years ago

Looks to be an issue with the previewer (possibly a caching one - it may be pulling an older version of the css), this works: https://raw.githack.com/StatCan/kubeflow-containers-desktop/landingpage/base/resources/landing_page/index.html

Though my CSS was very fast and loose for a quick proof of concept, with text changed to get things to align better (wrt e.g. centering), so there should still be a better way to set things up with a more explicit structure.

frazs commented 4 years ago

In today's stand-up, @brendangadd said he wanted to go over the HTML for best practices and accessibility before this is pulled in. I'm putting this in Draft until that's done.

For anyone reviewing this, note that one way or another the URLs must be dynamically built (but perhaps it is possible to dynamically build a string that's fed into an <a href ...> if that is what is best for e.g. screen readers). This is because of the dynamic workspace base URL component (the part that is /notebook/namespace/container-name/). Or at least in my attempts to use relative links, they would attach directly to the kubeflow domain, which wouldn't work -- but perhaps I missed something.

frazs commented 4 years ago

Rebased to sync up with other recent updates. @wg102 is going to take a look.

frazs commented 4 years ago

While there please see if you can fix the "no newline" git warnings (IIRC Saffa had luck just adding a new line at the end) and I'm going to try to figure out why that keeps happening on my end.

wg102 commented 4 years ago

I modified the code to use 'a' elements instead and verified the navigation using tabs.

frazs commented 4 years ago

LGTM. @brendangadd?