search

StatCan / kubeflow-containers-desktop

Experimental containers to be used with Kubeflow for a Desktop experience
Other
1 stars 2 forks source link

fix: update firefox version to prevent crashes #64

Closed ca-scribner closed 3 years ago

ca-scribner commented 3 years ago

Bump firefox to current version. I've tested briefly and the previous version (76-something) crashed very frequently (on ~50% page loads) while the new version lasted for 10 minutes of testing.

ca-scribner commented 3 years ago

We can also back the version off a point or two if that’s easier for i18n. Pick whichever you prefer and give it a go! :D

On Tue, Feb 23, 2021 at 17:15 Jose Manuel (Ito) notifications@github.com wrote:

@Ito-Matsuda requested changes on this pull request.

Just concerning i18n on line 742 https://github.com/StatCan/kubeflow-containers-desktop/blob/90a6ae3e07b7a20c9b494d2187df514d277be844/base/Dockerfile#L742 it installs the French language pack. It may still work / i18nize but not 100% sure, can test just by adding ENV KF_LANG=fr somewhere and if that xpi package works it works.

Else Now in that same url directory I could not find an xpi file for firefox 86 but found one here

https://ftp.mozilla.org/pub/firefox/nightly/2020/12/2020-12-31-21-16-52-mozilla-central-l10n/linux-x86_64/xpi/

` https://ftp.mozilla.org/pub/firefox/nightly/2020/12/2020-12-31-21-16-52-mozilla-central-l10n/linux-x86_64/xpi/firefox-86.0a1.fr.langpack.xpi

I'm pretty sure that any language pack with 86 should work (which again can test easily with KF_LANG=fr and opening up the web browser

TLDR; Replace the wget target url with that one above?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/StatCan/kubeflow-containers-desktop/pull/64#pullrequestreview-596846747, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALPFPIZA57ISFLFB3CRWRQLTAQSJZANCNFSM4YDI66UA .

Jose-Matsuda commented 3 years ago

Scratch that above URL out of your memory, it will not work (tried on personal installation of firefox) https://addons.mozilla.org/en-US/firefox/addon/fran%C3%A7ais-language-pack/versions/

I was concerned with the fact that the URL would disappear but I found a URL from an older version (here is for 68)of Firefox linked in an issue here.

So what I will do is replace that line with the following instead https://addons.mozilla.org/firefox/downloads/file/3731010/francais_language_pack-86.0buildid20210222142601-fx.xpi

Streamable link

Jose-Matsuda commented 3 years ago

This is now a 'LGTM' from me