search

StatCan / kubeflow

Machine Learning Toolkit for Kubernetes
Apache License 2.0
0 stars 3 forks source link

[Epic] Pushing features upstream - Centraldashboard #54

Open saffaalvi opened 3 years ago

saffaalvi commented 3 years ago

After the Jupyter Web App features have been pushed upstream (progress being tracked in this EPIC https://github.com/StatCan/kubeflow/issues/45), we will need to move onto pushing our centrealdashboard changes upstream as well.

Changes made up until v1.2 have been documented in this issue: https://github.com/StatCan/kubeflow/issues/33. We will need to narrow down this list and decide which features and customizations we want to push upstream.

The process for pushing the centraldashboard changes upstream might be different than how we pushed our Jupyter Web App changes upstream. Since the Jupyter Web App component was basically re-written to be part of crud-web-apps and our jupyter-web-app component was in a different repo, jupyter-apis, we had to go the manual route to push everything upstream.

The centraldashboard component has not gone through such a major change and is still part of the same repo, so it might be possible to do a simple merge to push our features from this component upstream. We did first attempt to merge jupyter-apis into crud-web-apps/jupyter and this process was documented in this issue https://github.com/StatCan/kubeflow/issues/44, which can be referred to if trying a merge for the centraldashboard component.

This issue can later be converted into an EPIC like the Jupyter Web App one if it isn't just a simple merge and instead, there's a need to track individual issues and features.

Something to be noted is that it's important to start off with figuring out how to get a local development of the centraldashboard component upstream running so that changes can be tested before pushing anything.

The items to push are:

saffaalvi commented 3 years ago

It might be helpful to look at the steps of how we did the rebase to v1.2 as well. In that case, we brought in all of upstream's commits into our repo. This time, we want to do the opposite and bring our commits into upstream. https://github.com/StatCan/kubeflow/issues/34#issuecomment-738982914

wg102 commented 3 years ago

The list of things to push upstream would be : (WIP)

kanna823 commented 2 years ago

when would the above epic be resolved and released?