StatCan / openmpp

Implementing the OpenM++ microsimulation framework as a Kubernetes service on the StatCan cloud.
0 stars 1 forks source link

Job 'Run Name' and 'Set Name' cannot contain spaces #47

Closed vexingly closed 8 months ago

vexingly commented 10 months ago

Related to Jira OPENM-19.

The -OpenM.RunName and -OpenM.SetName parameters cause an error if a user uses a name with spaces.

Encapsulate the run name and any other user provided fields in quotes in the job template to avoid these errors.

KrisWilliamson commented 10 months ago

The same issue may also affect the -OpenM.RunStamp and -OpenM.LogFilePath

KrisWilliamson commented 9 months ago

The parseCommand.py script spits on spaces, so a trim on the value field would not be easy. Basically to handle this correctly would involve rewriting the entire parseCommand.py script.

KrisWilliamson commented 9 months ago

The parseCommand script has been rewritten to parse the command line arguments in a different way, which resolves this issue. The change is so great that care will be needed when merging.

KrisWilliamson commented 9 months ago

Also, error handling message passthrough was improved which resolves issue https://github.com/StatCan/openmpp/issues/58

KrisWilliamson commented 9 months ago

Made a small change to handle cases where extra spaces were introduced in certain places, notably at the end of the -Open.NotOnRoot argument.

KrisWilliamson commented 9 months ago

This change fixes issues https://github.com/StatCan/openmpp/issues/58 and https://github.com/StatCan/openmpp/issues/60, thereby superceeding them. Therefore issues 58 & 60 will be closed and their PRs deleted.

KrisWilliamson commented 9 months ago

In testing: The revised error message works, see issue https://github.com/StatCan/openmpp/issues/58 The image used is: k8scc01covidacrdev.azurecr.io/jupyterlab-cpu:openmpp-47

ERROR: path to MPI model executable does not exist
ERROR. Model executable not found:  /home/jovyan/buckets/aaw-unclassified/microsim/models/bin/OzProj_mpi
exit status 1
KrisWilliamson commented 9 months ago

In testing. The .ini file with selected output tables is being passed in to the executable and is running as expected. image image

KrisWilliamson commented 9 months ago

In testing. explicitly added spaces to the Run Name field, and the job ran This indicates that spaces in the Run Name field are being handled without causing an error.