Closed vexingly closed 8 months ago
The same issue may also affect the -OpenM.RunStamp and -OpenM.LogFilePath
The parseCommand.py script spits on spaces, so a trim on the value field would not be easy. Basically to handle this correctly would involve rewriting the entire parseCommand.py script.
The parseCommand script has been rewritten to parse the command line arguments in a different way, which resolves this issue. The change is so great that care will be needed when merging.
Also, error handling message passthrough was improved which resolves issue https://github.com/StatCan/openmpp/issues/58
Made a small change to handle cases where extra spaces were introduced in certain places, notably at the end of the -Open.NotOnRoot argument.
This change fixes issues https://github.com/StatCan/openmpp/issues/58 and https://github.com/StatCan/openmpp/issues/60, thereby superceeding them. Therefore issues 58 & 60 will be closed and their PRs deleted.
In testing: The revised error message works, see issue https://github.com/StatCan/openmpp/issues/58 The image used is: k8scc01covidacrdev.azurecr.io/jupyterlab-cpu:openmpp-47
ERROR: path to MPI model executable does not exist
ERROR. Model executable not found: /home/jovyan/buckets/aaw-unclassified/microsim/models/bin/OzProj_mpi
exit status 1
In testing. The .ini file with selected output tables is being passed in to the executable and is running as expected.
In testing. explicitly added spaces to the Run Name field, and the job ran This indicates that spaces in the Run Name field are being handled without causing an error.
Related to Jira OPENM-19.
The -OpenM.RunName and -OpenM.SetName parameters cause an error if a user uses a name with spaces.
Encapsulate the run name and any other user provided fields in quotes in the job template to avoid these errors.