StatEngine / stat-engine

A Real-Time Open Source Data Analytics and Visualization Platform for Public Safety
https://statengine.io
GNU General Public License v3.0
8 stars 5 forks source link

Concurrent Incidents #494

Closed bliitzkrieg closed 3 years ago

bliitzkrieg commented 4 years ago

Overview

Added ability to toggle concurrent incidents on map inside Incident analysis view

GitHub Issues

Changes

Screenshots / Videos

Screen Shot 2020-06-16 at 8 56 06 PM Screen Shot 2020-06-16 at 8 56 09 PM

Steps to Test

bliitzkrieg commented 4 years ago

@chopchop505 Should be good for review. Do you want to use a different icon for the toggle?

larskendall commented 3 years ago

I noticed one more thing that should probably be adjusted...

Right now there's some default styling for the incident map component that's mixed in the incident analysis page's css (.incident-map-container and .incident-map-concurrent-layer in incident-analysis.scss), but I think that probably belongs in a file specifically for the incident map component, so that it's reusable. Otherwise you'd have to set the styling for that stuff again for any page where you want to reuse the concurrent incidents toggle button.

bliitzkrieg commented 3 years ago

Should be good for review

larskendall commented 3 years ago

Looks great! I'll merge it in.