search

StatTag / StatWrap

StatWrap
https://sites.northwestern.edu/statwrap/
MIT License
1 stars 10 forks source link

Dependency Tree branch once opened does not retract back on closing #182

Closed AdiAkhileshSingh15 closed 7 months ago

AdiAkhileshSingh15 commented 8 months ago

Description

This issue aims to make the Dependency Tree Structure Interface tidy and readable to user.

Screenshot from 2024-03-08 21-43-23 When the app branch is opened.

Screenshot from 2024-03-08 21-43-56 When the app branch is closed.

Here, it leaves the tree skeleton upto what it was opened before that point, behind the current tree structure, which I don't think serves any purpose and leaves the UI pretty cluttered. I'm trying to find a fix for this, as I was going through the ReactEcharts module props for tree type. I'd be happy to take this issue up, if it is one.

@lrasmus Please take a look a it.

lrasmus commented 8 months ago

@AdiAkhileshSingh15 - thank you for pointing this out, I agree it's an error! Assigned to you, if you're willing to investigate.

AdiAkhileshSingh15 commented 8 months ago

Update

While trying to fix this, I discovered what's causing this issue is the data object. What I noticed is that it works fine if I give it the data object in the same form but hard-coded, than using the StatWrap methods to generate the data. I don't understand why, even if I deconstruct the data object into just name and children, which is how the docs for echarts-for-react do, it doesn't work, or even passing it through a wrapper function to transform data doesn't help. So, I just don't understand what exactly is wrong with the data object. But, am sure what's causing the issue is definitely data and not the other attributes of option prop, as it works fine for hard-coded data as I said.

Potential Issue: What may actually be causing the issue, as I discussed with @lrasmus, is the complexity of the data generated by StatWrap, or the inability of the rendering package to deal with such complex data. I raised this issue in the parent repository of this package, which you can find here. Still waiting for the response though :)) Dunno, maybe upvotes or smthg can work.

Way forward: So, am further investigating it if that's the real issue by passing in some complex hard-coded data. And on confirming that, will look for new packages which can come of some help.