Closed AdiAkhileshSingh15 closed 6 months ago
@lrasmus, I wanted to highlight the 3rd commit in this PR (acf3c3d), which focuses on resolving eslint issues using lint-fix
. Since it involves numerous files and only addresses linting errors without introducing any breaking changes, I've already reviewed and confirmed each syntax correction. Hence, I recommend skipping a detailed review of this commit as it primarily consists of eslint syntax fixes.
@lrasmus do check the introduction of title
dependency in app/components/EditableSelect/EditableSelect.js
useEffect.
@lrasmus do check the introduction of
title
dependency inapp/components/EditableSelect/EditableSelect.js
useEffect.
Thanks for mentioning that! I did notice it, and when testing it didn't seem to impact the functionality (from what I could tell). Curious if you know why the linter recommended it, and how strong the recommendation is? I'm okay keeping it if there is a good reason. I'm equally okay ignoring the linter's suggestion there and reverting to how it was before.
@lrasmus Actually, linter suggests adding all dependencies in the useEffect
dependency array to ensure it triggers appropriately. While there are similar suggestions across our project, this one appeared reasonable to implement compared to others. I've opted not to disable this warning globally, as some suggestions may prove helpful in the future. We can selectively disable them based on how strong the recommendation is.
I think that sounds like a good approach @AdiAkhileshSingh15!
@lrasmus I've updated the branch with latest changes in master. It's ready to merge, if all reviews are done.
@lrasmus please check latest push
Amazing, thank you so much @AdiAkhileshSingh15 !
Changes Overview
This PR aims to address unwanted ESlint failures and false positive errors by implementing the following changes:
eslint-formatter-pretty
package from v6 to v5. This adjustment is necessary because v6 is currently incompatible with ESlint due to its usage of cjs instead of esm. You can find more details about this issue here.yarn run lint-fix
to identify and address any remaining ESlint errors by clearing out syntactical error warnings.Related Issue π
Fixes #169
Checklist β
Following each commit, the following checks were executed locally to ensure the functionality remains intact:
Commands used:
yarn test
- All tests passed successfully.yarn dev
- No UI failures were observed.yarn build
- The build process completed without errors.yarn dev
- No new console errors were detected for any dependencies.Additional checks:
yarn run lint-fix
.Reviewer
@lrasmus