Gin trunk is incompatible to GWT trunk because of recent Guava 15 refactoring in GWT

Statary / google-gin

Automatically exported from code.google.com/p/google-gin

0 stars 0 forks source link

Gin trunk is incompatible to GWT trunk because of recent Guava 15 refactoring in GWT #195

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

Gin trunk still uses 

com.google.gwt.dev.util.Preconditions

and possibly other classes that have been removed in GWT trunk. GWT now uses 
Guava 15 equivalents repackaged under 

com.google.gwt.thirdparty.guava

Original issue reported on code.google.com by jens.neh...@gmail.com on 28 Oct 2013 at 3:44

GoogleCodeExporter commented 9 years ago

Actually, this is fixed internally but not released to svn. I think we can just 
update trunk without a maven release.

Original comment by gok...@google.com on 28 Oct 2013 at 7:25

GoogleCodeExporter commented 9 years ago

Would be fine for me. Using GIN trunk anyways. 

For the time being I re-added a guava copy to our cloned GWT trunk at the 
required package.

Original comment by jens.neh...@gmail.com on 28 Oct 2013 at 7:27

GoogleCodeExporter commented 9 years ago

I exported the internal fix for this in r278.

Original comment by aragos on 1 Nov 2013 at 7:46

Changed state: Fixed

GoogleCodeExporter commented 9 years ago

Issue 197 has been merged into this issue.

Original comment by aragos on 18 Nov 2013 at 6:06

GoogleCodeExporter commented 9 years ago

Issue 197 has been merged into this issue.

Original comment by aragos on 24 Nov 2013 at 6:14