StateOfCalifornia / CalCAT

California Communicable diseases Assessment Tool
MIT License
225 stars 101 forks source link

grab_can_county_observed_interventions Function #12

Closed AK-MCH-EPI closed 4 years ago

AK-MCH-EPI commented 4 years ago

Working through the code to apply to Alaska and noting an issue with the grab_can_county_observed_intervention function. This appears to stem from the loop_can_cnty_observed function where the can.ca.co object returns a null. I can hard code this by specifying each fips code explicitly but the lapply function keeps failing.

Will work with it a bit to come up with my own solution but also reaching out to see if this is a simple oversight on my part.

upon further inspection it appears to be related to the RCurl::url.exists(url) code in the loop function returning false for all values.

vargoCDPH commented 4 years ago

have corrected the loop_can functions to remedy this. the Rcurl:: version of the url.exists function was always returning false in some environments.

AK-MCH-EPI commented 4 years ago

Thanks so much, I made a similar fix to it as well on my local copy. Thanks for sharing all this work.

From: vargoCDPH [mailto:notifications@github.com] Sent: Wednesday, July 8, 2020 1:51 PM To: StateOfCalifornia/CalCAT CalCAT@noreply.github.com Cc: Parrish, Jared W (HSS) jared.parrish@alaska.gov; Author author@noreply.github.com Subject: Re: [StateOfCalifornia/CalCAT] grab_can_county_observed_interventions Function (#12)

have corrected the loop_can functions to remedy this. the Rcurl:: version of the url.exists function was always returning false in some environments.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/StateOfCalifornia/CalCAT/issues/12*issuecomment-655776614__;Iw!!J2_8gdp6gZQ!5cc-nuKxOPsL9DseqingaPQhM80kc_UoffgI2NQRtJkpEuFuW9yGfoxor8yBiA-d_We0Pg$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AF3KQQHALBOJHJXT3SAQDXTR2TS4XANCNFSM4OJYXFHA__;!!J2_8gdp6gZQ!5cc-nuKxOPsL9DseqingaPQhM80kc_UoffgI2NQRtJkpEuFuW9yGfoxor8yBiA807aDNwQ$.