StateVoicesNational / Spoke

mass-contact text/SMS distribution tool
Other
460 stars 400 forks source link

make redis tests work #2359

Closed lperson closed 2 months ago

lperson commented 3 months ago

Fixes # (issue)

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change, and any blockers that make your change a WIP

Checklist:

engelhartrueben commented 2 months ago

Hey Larry,

Just want to first thank you for working on this! Absolute life saver!

I did get this all to pass locally (w/ NGPVAN) in two ways: 1. by setting the jest.setTimeout to 25,000ms in __test__/setup.js. This NGPVAN test looks to take around 20 seconds while running all the other tests alongside it, so some headroom was necessary. 2. by running __test__/extensions/contact-loaders/ngpvan/ngpvan.test.js by itself w/ the original timeout.

It seems this was extended in the past for one of the campaign tests from the default 5,000ms to 15,000ms.

Would it be viable to only allow the timeout extension for just the the NGPVAN test? Or could we comfortably extend it globally?

I understand it may not be best practice to just extend the timer without finding the root cause, so just exploring options!

engelhartrueben commented 2 months ago

If you have a second @mau11 , my last commit needs to be removed. No point in extending the jest timeout since that was never the problem. I can get to it later tonight if not!

lperson commented 2 months ago

@engelhartrueben I changed the timeout back to 15000

engelhartrueben commented 2 months ago

πŸŽ‰πŸŽ‰πŸŽ‰