StateVoicesNational / Spoke

mass-contact text/SMS distribution tool
Other
460 stars 400 forks source link

Upgrade dotenv to 16.4.5 #2370

Closed stefanhayden closed 1 week ago

stefanhayden commented 1 month ago

Fixes # (issue)

Description

dotenv from 2.0.0 to 16.4.5

changelog here. nothing breaking seems to effect this app. https://github.com/motdotla/dotenv/blob/master/CHANGELOG.md

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change, and any blockers that make your change a WIP

Checklist:

engelhartrueben commented 1 month ago

Thanks for spotting this. Once we get the 14.1 branch ready, we will review and merge this in.

More for my sake when coming back to this: dotenv 15.0.0 breaks # when used in a variable as it considers it a comment, unless wrapped in quotes. Looking into our current build, we don't use # other than comments, but may be good to mention in the release notes. This is more for local development, as pm2 already requires quotes when running prod, while yarn dev does not.

engelhartrueben commented 1 week ago

Hey @stefanhayden, Can you rebase this as well to get up to date with stage-main-14.1?

stefanhayden commented 1 week ago

@engelhartrueben rebased!