StaticJsCMS / static-cms

A Git-based CMS for Static Site Generators
https://staticjscms.netlify.app/
MIT License
595 stars 52 forks source link

Convert to Material UI #15

Closed KaneFreeman closed 2 years ago

KaneFreeman commented 2 years ago

Switch to material UI

DavidWells commented 2 years ago

This project looks cool. Thanks for this fork!

Quick question: What's the idea behind using MUI for this?

Those components are pretty beefy https://bundlephobia.com/package/@mui/material@5.10.10 bundlesize wise.

Here are a couple of other potentially lighter-weight alternatives:

Anywho, totally up to you, just thought I'd share some component libs that might help.

KaneFreeman commented 2 years ago

So the choice of Material UI comes down to a combination of my familiarity with the library (I have been using it for years), it covers a lot of the scenarios we need (and some I want to add) and my own personal preference towards Material Design in general.

Switching to it has allowed me to remove several other independent dependencies and drastically reducing the size of our own code base (as a lot of the styling previously was custom). This will help a lot with maintaining the code base. It also is build on top of @emotion which the repo was already using. And yes bundle size is a concern still and I am taking steps to reduce it at much as possible (see: https://mui.com/material-ui/guides/minimizing-bundle-size/).

Here are a few other benefits the library gives:

KaneFreeman commented 2 years ago

Resolved in #44