search

StaticMania / keep-react

Keep React is an open-source component library built on Tailwind CSS and React.js. It provides a versatile set of pre-designed UI components to build modern web applications.
https://react.keepdesign.io
MIT License
1.34k stars 113 forks source link

Refractor: Removed a depreacated depenedency #104

Closed codernex closed 10 months ago

codernex commented 10 months ago

Removed @types/rc-slider@9.3.1 while rc-slider provides its type definitions. image

vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 22, 2023 9:47am
vercel[bot] commented 10 months ago

@codernex is attempting to deploy a commit to the StaticMania Team on Vercel.

A member of the Team first needs to authorize it.

Arifulislam5577 commented 10 months ago

Hi @codernex,

Thank you for addressing the deprecated dependency and for the update! We appreciate your efforts in keeping the project dependencies up to date.

Regarding the package manager switch, we've adjusted the configuration to use Yarn instead of pnpm. You can now pull the changes from the main branch to resolve any potential conflicts.

If you have any questions or encounter any issues during this process, feel free to reach out. Thanks again for your contribution!

Best regards, @Arifulislam5577

codernex commented 10 months ago

Hi @Arifulislam5577,

Should I close this pull request and create a new one? I noticed that @types/rc-slider is present in package.json on the main branch.

And you guys should update the code to support pnpm also as npm & yarn is much slower than pnpm

Arifulislam5577 commented 10 months ago

Hi @codernex,

Thank you for bringing up the suggestion to support pnpm in our project! We truly appreciate your valuable feedback.

We understand that pnpm can offer improved performance compared to npm and yarn, and we agree that supporting pnpm is important for our users. Rest assured, we have taken note of your suggestion, and our team is actively working on updating the code to include pnpm support.

Your input is crucial to the continuous improvement of our project, and we are grateful for your engagement. If you have any further suggestions or questions, please feel free to share them with us.

Best regards, Md Ariful Islam