Closed shuvo-me closed 7 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
keep-react | ❌ Failed (Inspect) | Feb 18, 2024 9:53am |
@shuvo-me is attempting to deploy a commit to the StaticMania Team on Vercel.
A member of the Team first needs to authorize it.
@Arifulislam5577 vai you can check the pr. thanks
Hi @shuvo-me,
Thank you for your contribution to our Keep React documentation! Adding a top progress bar while changing routes is indeed a great enhancement for improving user experience. This feature will provide visual feedback to users, letting them know that their action (such as clicking on a link) has been acknowledged and is being processed.
However, you've added the "next-nprogress-bar" package as a dependency, but we believe it should be included as a devDependency instead. Since this package does not directly affect our Keep React components, placing it in devDependencies would be more appropriate for our code structure. Could you please adjust this and commit it again? Remember that commit messages should start with a capital letter and end with a period.
We appreciate your effort in making our documentation more user-friendly. Your contribution aligns perfectly with our goal of continually improving the usability and accessibility of our platform.
Looking forward to your next contribution!
Best regards, Md Ariful Islam.
Hi @shuvo-me,
Thank you for your contribution to our Keep React documentation! Adding a top progress bar while changing routes is indeed a great enhancement for improving user experience. This feature will provide visual feedback to users, letting them know that their action (such as clicking on a link) has been acknowledged and is being processed.
However, you've added the "next-nprogress-bar" package as a dependency, but we believe it should be included as a devDependency instead. Since this package does not directly affect our Keep React components, placing it in devDependencies would be more appropriate for our code structure. Could you please adjust this and commit it again? Remember that commit messages should start with a capital letter and end with a period.
We appreciate your effort in making our documentation more user-friendly. Your contribution aligns perfectly with our goal of continually improving the usability and accessibility of our platform.
Looking forward to your next contribution!
Best regards, Md Ariful Islam.
Thanks @Arifulislam5577 vai. I love to contribute to this type of awesome project in my free time. Nice to meet you.
Hi @shuvo-me,
Thank you for your contribution to our Keep React documentation! Adding a top progress bar while changing routes is indeed a great enhancement for improving user experience. This feature will provide visual feedback to users, letting them know that their action (such as clicking on a link) has been acknowledged and is being processed.
We've reviewed your changes, and everything looks perfect! Your attention to detail and prompt response are greatly appreciated.
The pull request has been merged successfully, and we're excited to see your next contribution. Keep up the fantastic work!
Best regards, Md Ariful Islam
Hi @shuvo-me vai please create a new pull request with the latest code in this feature so that I can add your in our contributor list. I forgot to add you in our contributor list.
https://www.loom.com/share/71a499a193f940ceba090c0c23b5bc47