search

StaticMania / keep-react

Keep React is an open-source component library built on Tailwind CSS and React.js. It provides a versatile set of pre-designed UI components to build modern web applications.
https://react.keepdesign.io
MIT License
1.32k stars 115 forks source link

Implement button behavior property #83

Closed saiful7778 closed 9 months ago

saiful7778 commented 10 months ago

I changed Button component "type" prop to "buttonType" and PlayButton. I also added button "type" prop, the default value in 'button'. It can take 'button' | 'submit' | 'reset'. The default value is 'button'. It is an optional prop.

Fixed #82

In JSX: Screenshot from 2023-11-24 01-00-30

In browser HTML: Screenshot from 2023-11-24 01-02-23

netlify[bot] commented 10 months ago

Deploy Preview for keep-react-sm failed.

Name Link
Latest commit cc164b4a36568bea9cd1245e38a01384e773126a
Latest deploy log https://app.netlify.com/sites/keep-react-sm/deploys/6560491e84ccca000839e792
Arifulislam5577 commented 10 months ago

Hi @saiful7778,

We deeply appreciate your outstanding contribution to our Keep React project, particularly for implementing the button behavior property.

Upon code review, we suggest changing the buttonType prop to variant to better align with its purpose and enhance overall clarity. Your cooperation in making this adjustment would be highly valuable.

After making the change, please commit and push the updated code. This modification ensures that the variant prop seamlessly integrates with our Keep React package in the upcoming version. Please use yarn instead of pnpm.

Thank you once again for your commitment to enhancing Keep React!

Best regards, Md Ariful Islam

saiful7778 commented 10 months ago

I can't understand why netlify gets error

kypanz commented 7 months ago

Hello guys, is this solved ?, i am trying to use a button like submit but i am not sure how :fearful: