StaticYolt / SW2StuffingGeneratorComponent

0 stars 0 forks source link

Repo Organizational Issues #1

Open jrg94 opened 2 months ago

jrg94 commented 2 months ago

I think since you put all your code in Eclipse, I had a little bit of trouble finding what I needed. For example, the /doc directory is missing but /bin is included (which we don't usually want binaries stored in git). Similarly, there are DS Store files floating around that I would recommend excluding through the gitignore.

I am also somewhat unsure where your two use cases are.

Finally, I generally recommend cleaning up comments before submission (or in this case, committing). There are several bits of code commented out. I would delete those sections if they are not needed.

StaticYolt commented 2 months ago

Thanks for taking the time to look over the project,

Here are all the test cases which may show some use cases: https://github.com/StaticYolt/SW2StuffingGeneratorComponent/tree/main/test This file may also show some use cases of the component: https://github.com/StaticYolt/SW2StuffingGeneratorComponent/blob/main/src/Playground.java

I just hid the DS store file, to be honest I don't know what it means. Also my doc directory didn't have any files and should I hide my bin?

Let me know if I can be of any assistance with my code (sorry its a lil mess), gl grading and say hi to baby for me!

Sincerely, Leo Cheng

On Fri, Apr 26, 2024 at 2:12 PM Jeremy Grifski @.***> wrote:

I think since you put all your code in Eclipse, I had a little bit of trouble finding what I needed. For example, the /doc directory is missing but /bin is included (which we don't usually want binaries stored in git). Similarly, there are DS Store files floating around that I would recommend excluding through the gitignore.

I am also somewhat unsure where your two use cases are.

— Reply to this email directly, view it on GitHub https://github.com/StaticYolt/SW2StuffingGeneratorComponent/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6C3V3NWSRTAHJ4H2BIQJETY7KKG7AVCNFSM6AAAAABG3GWMPGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI3DMMRXHA4DSNQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

StaticYolt commented 2 months ago

Hi Jermey!

Hope everything is going well and to make this as easy as possible for you, I will send below, the final project in a zip file, the link to github, and the md file as a pdf.

Github Repo: https://github.com/StaticYolt/SW2StuffingGeneratorComponent/tree/main

Thank you so much!

Sincerely, Leo Cheng

On Sat, Apr 27, 2024 at 11:56 AM Leo Cheng @.***> wrote:

Thanks for taking the time to look over the project,

Here are all the test cases which may show some use cases: https://github.com/StaticYolt/SW2StuffingGeneratorComponent/tree/main/test This file may also show some use cases of the component: https://github.com/StaticYolt/SW2StuffingGeneratorComponent/blob/main/src/Playground.java

I just hid the DS store file, to be honest I don't know what it means. Also my doc directory didn't have any files and should I hide my bin?

Let me know if I can be of any assistance with my code (sorry its a lil mess), gl grading and say hi to baby for me!

Sincerely, Leo Cheng

On Fri, Apr 26, 2024 at 2:12 PM Jeremy Grifski @.***> wrote:

I think since you put all your code in Eclipse, I had a little bit of trouble finding what I needed. For example, the /doc directory is missing but /bin is included (which we don't usually want binaries stored in git). Similarly, there are DS Store files floating around that I would recommend excluding through the gitignore.

I am also somewhat unsure where your two use cases are.

— Reply to this email directly, view it on GitHub https://github.com/StaticYolt/SW2StuffingGeneratorComponent/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6C3V3NWSRTAHJ4H2BIQJETY7KKG7AVCNFSM6AAAAABG3GWMPGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI3DMMRXHA4DSNQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>