Open mashfiqui-rabbi opened 4 years ago
Hi Mash,
I could take a look of this, but the issue is that my android phone doesn't have any problem even I turn on text"huge", I am not sure how I can test on this issue...
Liying
From: Mashfiqui notifications@github.com Sent: Sunday, May 3, 2020 5:09 PM To: StatisticalReinforcementLearningLab/SARAv2 SARAv2@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [StatisticalReinforcementLearningLab/SARAv2] Accessibility setting is cutting off radio button texts (#88)
When the "larger text" accessibility setting is on, the texts for radio buttons are cutting off (see image below). Larger text sizes are not often enabled on the phones for an AYA, that is why we never saw this bug. But for older population, larger text sizes will be likely enabled.
Mobile accessibility is also highly talked in health research these days, so this is an important fix.
More on mobile accessibility on ionic can be found in the following link.
https://ionicframework.com/docs/v3/native/mobile-accessibility/https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fionicframework.com%2Fdocs%2Fv3%2Fnative%2Fmobile-accessibility%2F&data=02%7C01%7Clxh37%40psu.edu%7Cc968540f90744dffe11508d7efa64211%7C7cf48d453ddb4389a9c1c115526eb52e%7C0%7C0%7C637241369675165179&sdata=c3PKUEE9aWF6DhLSBTN8ps59DcvxmjhvVT0uGOyHyNY%3D&reserved=0
Check the functions getTextZoom and setTextZoom
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FStatisticalReinforcementLearningLab%2FSARAv2%2Fissues%2F88&data=02%7C01%7Clxh37%40psu.edu%7Cc968540f90744dffe11508d7efa64211%7C7cf48d453ddb4389a9c1c115526eb52e%7C0%7C0%7C637241369675175181&sdata=pkZncrGrJ6ZOYXwW5tYfxgtUIdoBWEsOZYqAC0Vsj7I%3D&reserved=0, or unsubscribehttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADXW5ZK27KLPQZ4XDQHZB3DRPXMQHANCNFSM4MYJKHHQ&data=02%7C01%7Clxh37%40psu.edu%7Cc968540f90744dffe11508d7efa64211%7C7cf48d453ddb4389a9c1c115526eb52e%7C0%7C0%7C637241369675185172&sdata=i6%2Fy9GexXcG9dnqn3QUdhSXoo9Jx%2BBPcj0wyYH7k18g%3D&reserved=0.
I added the changes you made, but can you add the mobile accessibility and disable it on all pages?
Thank you again.
Sure, no need to disable it for all pages, just turn it on, it will last. I will do it today.
Liying
From: Mashfiqui notifications@github.com Sent: Saturday, May 16, 2020 2:45 PM To: StatisticalReinforcementLearningLab/SARAv2 SARAv2@noreply.github.com Cc: Huang, Liying lxh37@psu.edu; Assign assign@noreply.github.com Subject: Re: [StatisticalReinforcementLearningLab/SARAv2] Accessibility setting is cutting off radio button texts (#88)
I added the changes you made, but can you add the mobile accessibility and disable it on all pages?
Thank you again.
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FStatisticalReinforcementLearningLab%2FSARAv2%2Fissues%2F88%23issuecomment-629689995&data=02%7C01%7Clxh37%40psu.edu%7C8f91cc68c6f247591f4a08d7f9c958bb%7C7cf48d453ddb4389a9c1c115526eb52e%7C0%7C0%7C637252515481323194&sdata=GUc1XB2xU%2BygMVKY9nu2vFimIl6C%2Fyp3lBUppIMobWA%3D&reserved=0, or unsubscribehttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADXW5ZL77DRHUVAYUZOB5MDRR3NNTANCNFSM4MYJKHHQ&data=02%7C01%7Clxh37%40psu.edu%7C8f91cc68c6f247591f4a08d7f9c958bb%7C7cf48d453ddb4389a9c1c115526eb52e%7C0%7C0%7C637252515481333188&sdata=pY7qGTfXhwGnf6rdb%2F5EOamcE6Dqwi3lTOPS%2Brw1siA%3D&reserved=0.
When the "larger text" accessibility setting is on, the texts for radio buttons are cutting off (see image below). Larger text sizes are not often enabled on the phones for an AYA, that is why we never saw this bug. But for an older population, larger text sizes will be likely enabled.
Mobile accessibility is also highly talked in health research these days, so this is an important fix. We will also likely get older population at some point in the future.
More on mobile accessibility on ionic can be found in the following link.
Check the functions
getTextZoom
andsetTextZoom