search

StatisticalRethinkingJulia / TuringModels.jl

Implementations of the models from the Statistical Rethinking book with Turing.jl
https://statisticalrethinkingjulia.github.io/TuringModels.jl/
MIT License
163 stars 18 forks source link

Rename chains to chns #65

Closed BobinMathew closed 3 years ago

BobinMathew commented 3 years ago

Issue #64

I renamed all chains to chns except for chains inside comments/documentation(eg:-'''content''') and Chains(with uppercase 'C').

rikhuijzer commented 3 years ago

Thanks for your work. However, CI fails so something is wrong. Did you change the occurrence in utils.jl too?

BobinMathew commented 3 years ago

No, I only made changes in the files inside scripts I didn't change anything in utils.jl

BobinMathew commented 3 years ago

The warning occurred at this file 👇 'models/partial-pooling-estimates.md'

this leads to 'scripts/partial-pooling-estimates.jl'

rikhuijzer commented 3 years ago

I see many more errors too. There is also an occurrence of chains in utils.jl used for \defaultoutput. See function lx_defaultoutput

BobinMathew commented 3 years ago

I see many more errors too. There is also an occurrence of chains in utils.jl used for \defaultoutput. See function lx_defaultoutput

yes I see it, I have to change chains to chns in them too right?

rikhuijzer commented 3 years ago

yes I see it, I have to change chains to chns in them too right?

Yes, if you look at the source code for a file and the output on the website, you see why. To test locally whether everything works again go into your cloned version of this repository and run 

julia --project -ie 'using Franklin; Franklin.serve()'

(This takes 20 minutes on the first run, but of course you can just do other things in the meantime.) If that doesn't show any errors, then the CI job will probably also pass and I can merge your changes.