insilentio
commented
2 years ago -- Be advised, row numbers refer to pull request "1400 review" version --
- r170: why group by year? only one year available
- r191: same
- r295: same. Removal would also render obsolete the
ungroup()statement (as summarise does that already for the last grouping level) - r310ff: maybe a case for a function? gets complicated, difficult to grasp, and repetitive. Instead maybe:
mutate(differ = pop_limit - pop_theo,
new_ims = in_decr(differ, ims, FALSE),
new_ems = in_decr(differ, ems, TRUE), ...(in_decr() added at very end of file for demo purposes) However, code for in-/decrease is checked and works correctly. Not sure how param values for less_ims/more_ims are obtained, though. - r342: we should really pack everything into functions. This is a case for
stopifnot() - r379: same as r170
- r388: please explain calculation: what is rel?
- r409:
mutate(age = age + 1) - r444ff: I know you hate for some reasons overwriting variables. But assigning variables w/o using them later on doesn't make sense either. Why not simply:
out_bir %>% arrange(district, year, sex, origin) %>% write_csv(paste0(out_path, "/births_future.csv"))
furthermore re-formatted according style guide (let's discuss)
rosinklemens
1400_demography-housing.r
in particular: correction ims3, ems3. If the correction in immigration and emigration is not sufficient for the total limit correction