StavWasPlayZ / Even-More-Instruments

Add even more instruments to your Minecraft experience!
https://curseforge.com/minecraft/mc-mods/even-more-instruments
GNU General Public License v3.0
1 stars 2 forks source link

Brass recipe #12

Closed NukolLodda closed 1 month ago

NukolLodda commented 1 month ago

So I was looking at the crafting recipes and since I am going to include your mod into a modpack, I was thinking some of the recipes are a bit too expensive so what if the recipes for the saxophone and the trombony are switched to being made with brass if this mod is played alongside another mod that adds brass/registers brass into the tags.

StavWasPlayZ commented 1 month ago

Hey! I'm uncertain if I can 100% do it, because recipes are data-driven and not hardcoded.

But I can definitely look into it.
I also agree that the recipes are a lil' pricey 😅

Would you please be able to provide me the name of the mod you're speaking of?
Also, if you could suggest another vanilla recipes for these problematic instruments - what would you make them?

Looking forward 🙃

NukolLodda commented 1 month ago

I would say that create is a good example of the mod I'm talking about that adds brass, but if possible I would also like to make this idea work in general.

On Sat, Oct 19, 2024 at 8:34 AM StavWasPlayZ @.***> wrote:

Hey! I'm uncertain if I can 100% do it, because recipes are data-driven and not hardcoded.

But I can definitely look into it. I also agree that the recipes are a lil' pricey 😅

Would you please be able to provide me the name of the mod you're speaking of? Also, if you could suggest another vanilla recipes for these problematic instruments - what would you make them?

Looking forward 🙃

— Reply to this email directly, view it on GitHub https://github.com/StavWasPlayZ/Even-More-Instruments/issues/12#issuecomment-2423855463, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3MMEPDUR7H532FETPMX4TTZ4JNXTAVCNFSM6AAAAABQHPGD2OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRTHA2TKNBWGM . You are receiving this because you authored the thread.Message ID: @.***>

NukolLodda commented 1 month ago

also, are they data driven as in you write the json files yourself and then you put them in the recipes folder, or are they generated by a java file b/c if they are generated by a java file then my idea shouldn't be too hard to implement.

On Sat, Oct 19, 2024 at 8:41 AM Nukol Lodda @.***> wrote:

I would say that create is a good example of the mod I'm talking about that adds brass, but if possible I would also like to make this idea work in general.

On Sat, Oct 19, 2024 at 8:34 AM StavWasPlayZ @.***> wrote:

Hey! I'm uncertain if I can 100% do it, because recipes are data-driven and not hardcoded.

But I can definitely look into it. I also agree that the recipes are a lil' pricey 😅

Would you please be able to provide me the name of the mod you're speaking of? Also, if you could suggest another vanilla recipes for these problematic instruments - what would you make them?

Looking forward 🙃

— Reply to this email directly, view it on GitHub https://github.com/StavWasPlayZ/Even-More-Instruments/issues/12#issuecomment-2423855463, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3MMEPDUR7H532FETPMX4TTZ4JNXTAVCNFSM6AAAAABQHPGD2OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRTHA2TKNBWGM . You are receiving this because you authored the thread.Message ID: @.***>

StavWasPlayZ commented 1 month ago

Data generation in Minecraft is just that - making the JSONs in your term.

I don't do that, rather I make the JSONs myself.

But now that I think of it, if I just include an "invalid" block ID and it is unpresent, Minecraft will just ignore it.

So yeah, it's very much possible.

Either way, please do share a recipe suggestion if you can! 🙂

NukolLodda commented 1 month ago

the recipe idea I have in mind is literally just replace the copper and the gold in those recipes w/ blocks/brass for the blocks and ingots/brass for the ingots

On Sat, Oct 19, 2024 at 8:48 AM StavWasPlayZ @.***> wrote:

Data generation in Minecraft is just that - making the JSONs in your term.

I don't do that, rather I make the JSONs myself.

But now that I think of it, if I just include an "invalid" block ID and it is unpresent, Minecraft will just ignore it.

So yeah, it's very much possible.

Either way, please do share a recipe suggestion if you can! 🙂

— Reply to this email directly, view it on GitHub https://github.com/StavWasPlayZ/Even-More-Instruments/issues/12#issuecomment-2423878451, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3MMEPBR7UNOANROP6AU5ULZ4JPMVAVCNFSM6AAAAABQHPGD2OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRTHA3TQNBVGE . You are receiving this because you authored the thread.Message ID: @.***>

StavWasPlayZ commented 1 month ago

Well, fine enough then.

I'll just have you know that I never really played this mod myself, and I'm a bit contextless on that regard.. So apologies.

Nevertheless, I'll fetch the item/block IDs and implement them when I find the time.

Thanks for the suggestion!

StavWasPlayZ commented 1 month ago

Also, could I please get your target Minecraft version? So I know which to prioritize.

NukolLodda commented 1 month ago

most recent, 1.21 fabric is the version I'm on

On Sat, Oct 19, 2024 at 9:05 AM StavWasPlayZ @.***> wrote:

Also, could I please get your target Minecraft version? So I know which to prioritize.

— Reply to this email directly, view it on GitHub https://github.com/StavWasPlayZ/Even-More-Instruments/issues/12#issuecomment-2423904283, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3MMEPHKURRAUZ3YGPNPPRLZ4JRMNAVCNFSM6AAAAABQHPGD2OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRTHEYDIMRYGM . You are receiving this because you authored the thread.Message ID: @.***>

StavWasPlayZ commented 1 month ago

most recent, 1.21 fabric is the version I'm on

I have to say, I didn't particularly see Create for this version... But I'll release it for there anyways too, since I have some more fixes I'd like to push.