StavWasPlayZ / Even-More-Instruments

Add even more instruments to your Minecraft experience!
https://curseforge.com/minecraft/mc-mods/even-more-instruments
Other
1 stars 1 forks source link

New implementation for length of held instrument notes (e.g. violin) ? #13

Open theDerpu opened 2 days ago

theDerpu commented 2 days ago

Currently instruments like the violin have two options, long and short notes, this isn't great for variating quickly in songs.

Ideally, though it would take a bit of work I'd imagine, you have it start playing the note when you press the key, and stop when you let go of the key, this could be done by having a few sound samples for each key, one being the start note sound, then one for the loop that will play until the note is let go.

Alternatively just having other options for lengths could be nice but I can't think of another way to implement this well.

StavWasPlayZ commented 2 days ago

This was actually the plan for quite a long while!

I recently added API support for held instruments for the Nightwind Horn (took ages) - so in theory, all I really need to do now is just find appropriate held sounds for it (specifically attack, hold, and (optionally) release) and just adapt the Violin (and other)'s code.

There is also the issue of sound licensing, which I'm of course in under no financial state to even begin to cover.

So I'm pretty much just looking to open alternatives.

I personally really like the Synthesia ones, but they use Voice Crystal. I'll probably reach out to them to ask about license fees.

But yeah, will pin this to my TODO.