SteveNotSet
commented
3 months ago I will finish the job in a few days. A problem is that, the note labels in Chinese version of GI are kept as "do re mi", instead of "哆 来 咪". However, the keys in zh_cn.json are "哆 来 咪". Should I keep "do re mi" as what Mihoyo did, or translate them as "哆 来 咪"?
Steve is who?? @.***
------------------ 原始邮件 ------------------ 发件人: @.>; 发送时间: 2024年7月19日(星期五) 凌晨3:40 收件人: @.>; 抄送: "Steve Not @.>; @.>; 主题: [StavWasPlayZ/Genshin-Instruments] Translations Required - Chinese (Issue #16)
Hello,
I am in the process of shipping Genshin Instruments v4,0, and there are a bunch of new translation keys that are in need of translation. Expand to see diff (en_us.json) diff --git a/src/main/resources/assets/genshinstrument/lang/en_us.json b/src/main/resources/assets/genshinstrument/lang/en_us.json index da713ba..3a168f0 100644 --- a/src/main/resources/assets/genshinstrument/lang/en_us.json +++ b/src/main/resources/assets/genshinstrument/lang/en_us.json @@ -9,7 +9,8 @@ "item.genshinstrument.windsong_lyre": "Windsong Lyre", "item.genshinstrument.floral_zither": "Floral Zither", "item.genshinstrument.vintage_lyre": "Vintage Lyre", - "item.genshinstrument.glorious_drum": "Arataki's Great And Glorious Drum", + "item.genshinstrument.glorious_drum": "Arataki's Great and Glorious Drum", + "item.genshinstrument.nightwind_horn": "Nightwind Horn", "soundCategory.record": "Instruments", @@ -84,7 +85,8 @@ "button.genshinstrument.zither.soundType.new": "New", - "button.genshinstrument.label.do_re_mi": "Do Re Mi", + "button.genshinstrument.label.do_re_mi": "do re mi", + "button.genshinstrument.label.do_re_mi.description": "Labels will be of the musical notation \"do re mi.\"", "genshinstrument.label.do": "do", "genshinstrument.label.re": "re", @@ -99,10 +101,19 @@ "button.genshinstrument.label.keyboard_layout": "Keyboard", + "button.genshinstrument.label.keyboard_layout.description": "Labels will be of your local keyboard layout", "button.genshinstrument.label.qwerty": "Keyboard (QWERTY)", - "button.genshinstrument.label.note_name": "Note Name", - "button.genshinstrument.label.abc": "ABC", + "button.genshinstrument.label.qwerty.description": "Labels will be of the QWERTY keyboard layout", + "button.genshinstrument.label.note_name": "ABC", + "button.genshinstrument.label.note_name.description": "Labels will be of the musical notation \"ABC\"", + + "button.genshinstrument.label.fixed_abc": "Fixed ABC", + "button.genshinstrument.label.fixed_abc.description": "ABC labels that are not affected by custom transpositions (pitch)", + "button.genshinstrument.label.fixed_do_re_mi": "Fixed do re mi", + "button.genshinstrument.label.fixed_do_re_mi.description": "do re mi labels that are not affected by custom transpositions (pitch)", + "button.genshinstrument.label.none": "No Label", + "button.genshinstrument.label.none.description": "", "button.genshinstrument.label.don_ka": "Don-Ka", @@ -121,9 +132,12 @@ "genshinstrument.advancements.main.vintage_lyre.description": "Play the Vintage Lyre", "genshinstrument.advancements.main.glorious_drum.title": "Totally Not a Scam", - "genshinstrument.advancements.main.glorious_drum.description": "Play Arataki's Glorious Drum", + "genshinstrument.advancements.main.glorious_drum.description": "Play Arataki's Great and Glorious Drum", "genshinstrument.advancements.main.floral_zither.title": "Incognito Player", - "genshinstrument.advancements.main.floral_zither.description": "Play the Floral Zither" + "genshinstrument.advancements.main.floral_zither.description": "Play the Floral Zither", + + "genshinstrument.advancements.main.nightwind_horn.title": "The Final Symphony", + "genshinstrument.advancements.main.nightwind_horn.description": "Play the Nightwind Horn" }
Notably (though not fully all): "item.genshinstrument.nightwind_horn": "Nightwind Horn", "button.genshinstrument.label.do_re_mi.description": "Labels will be of the musical notation \"do re mi.\"", "button.genshinstrument.label.keyboard_layout.description": "Labels will be of your local keyboard layout", "button.genshinstrument.label.qwerty.description": "Labels will be of the QWERTY keyboard layout", "button.genshinstrument.label.note_name.description": "Labels will be of the musical notation \"ABC\"", "button.genshinstrument.label.fixed_abc": "Fixed ABC", "button.genshinstrument.label.fixed_abc.description": "ABC labels that are not affected by custom transpositions (pitch)", "button.genshinstrument.label.fixed_do_re_mi": "Fixed do re mi", "button.genshinstrument.label.fixed_do_re_mi.description": "do re mi labels that are not affected by custom transpositions (pitch)", "genshinstrument.advancements.main.nightwind_horn.title": "The Final Symphony", "genshinstrument.advancements.main.nightwind_horn.description": "Play the Nightwind Horn",
I have manually translated some of the keys, but I cannot ascertain that they are perfect. Would appreciate a PR on that matter.
CC @SteveNotSet
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>
StavWasPlayZ
Hello,
I am in the process of shipping Genshin Instruments v4,0, and there are a bunch of new translation keys that are in need of translation.
Expand to see diff (en_us.json)
```diff diff --git a/src/main/resources/assets/genshinstrument/lang/en_us.json b/src/main/resources/assets/genshinstrument/lang/en_us.json index da713ba..3a168f0 100644 --- a/src/main/resources/assets/genshinstrument/lang/en_us.json +++ b/src/main/resources/assets/genshinstrument/lang/en_us.json @@ -9,7 +9,8 @@ "item.genshinstrument.windsong_lyre": "Windsong Lyre", "item.genshinstrument.floral_zither": "Floral Zither", "item.genshinstrument.vintage_lyre": "Vintage Lyre", - "item.genshinstrument.glorious_drum": "Arataki's Great And Glorious Drum", + "item.genshinstrument.glorious_drum": "Arataki's Great and Glorious Drum", + "item.genshinstrument.nightwind_horn": "Nightwind Horn", "soundCategory.record": "Instruments", @@ -84,7 +85,8 @@ "button.genshinstrument.zither.soundType.new": "New", - "button.genshinstrument.label.do_re_mi": "Do Re Mi", + "button.genshinstrument.label.do_re_mi": "do re mi", + "button.genshinstrument.label.do_re_mi.description": "Labels will be of the musical notation \"do re mi.\"", "genshinstrument.label.do": "do", "genshinstrument.label.re": "re", @@ -99,10 +101,19 @@ "button.genshinstrument.label.keyboard_layout": "Keyboard", + "button.genshinstrument.label.keyboard_layout.description": "Labels will be of your local keyboard layout", "button.genshinstrument.label.qwerty": "Keyboard (QWERTY)", - "button.genshinstrument.label.note_name": "Note Name", - "button.genshinstrument.label.abc": "ABC", + "button.genshinstrument.label.qwerty.description": "Labels will be of the QWERTY keyboard layout", + "button.genshinstrument.label.note_name": "ABC", + "button.genshinstrument.label.note_name.description": "Labels will be of the musical notation \"ABC\"", + + "button.genshinstrument.label.fixed_abc": "Fixed ABC", + "button.genshinstrument.label.fixed_abc.description": "ABC labels that are not affected by custom transpositions (pitch)", + "button.genshinstrument.label.fixed_do_re_mi": "Fixed do re mi", + "button.genshinstrument.label.fixed_do_re_mi.description": "do re mi labels that are not affected by custom transpositions (pitch)", + "button.genshinstrument.label.none": "No Label", + "button.genshinstrument.label.none.description": "", "button.genshinstrument.label.don_ka": "Don-Ka", @@ -121,9 +132,12 @@ "genshinstrument.advancements.main.vintage_lyre.description": "Play the Vintage Lyre", "genshinstrument.advancements.main.glorious_drum.title": "Totally Not a Scam", - "genshinstrument.advancements.main.glorious_drum.description": "Play Arataki's Glorious Drum", + "genshinstrument.advancements.main.glorious_drum.description": "Play Arataki's Great and Glorious Drum", "genshinstrument.advancements.main.floral_zither.title": "Incognito Player", - "genshinstrument.advancements.main.floral_zither.description": "Play the Floral Zither" + "genshinstrument.advancements.main.floral_zither.description": "Play the Floral Zither", + + "genshinstrument.advancements.main.nightwind_horn.title": "The Final Symphony", + "genshinstrument.advancements.main.nightwind_horn.description": "Play the Nightwind Horn" } ```Notably (though not fully all):
I have manually translated some of the keys, but I cannot ascertain that they are perfect.
Would appreciate a PR on that matter.
Do note that it's on the dev branch.
CC @SteveNotSet
Thanks!