search

Steaf23 / BingoReloaded

Minecraft Bingo 1.18+ Plug-In
GNU General Public License v3.0
23 stars 10 forks source link

Add config setting to disable tool and armor durability #16

Closed chrisjanusa closed 1 year ago

chrisjanusa commented 1 year ago

Tested this on 1.19.4 and it worked for both tools and armor Tested that the "This boat has legs" achievement is still obtainable

Let me know any other scenarios you want me to test

image image
Steaf23 commented 1 year ago

I was thinking maybe instead of making it a config option it can be a setting in the settings menu, this is quite a bit of work so let me know if you are up for it

chrisjanusa commented 1 year ago

Yea I should be able to do that

chrisjanusa commented 1 year ago

@Steaf23 I moved it into the Player Effects section. Just let me know if you think there is a better home for it in the settings menus though.

chrisjanusa commented 1 year ago

Also I refactored the player effects menu a little so if you don't like any of the changes I made just let me know and I will revert them.

Steaf23 commented 1 year ago

This is generally a good change and exactly where I would put this feature, however there are a few things I had like to have changed. first off you still probably want to add this effect to the bingosettings and bingosettingsbuilder object, and implement the possibility for it to be entered via auto bingo command just like other effects.

Regarding the refactor, I dont think this is the best way, if you were to refactor this menu I think using an ActionMenu as the base class would work better since then you don't need to create a separate class object to just contain like 2 values. Let me know if you can fix these things and if not then ill merge and make the changes myself. (unless you disagree with me ig haha)

chrisjanusa commented 1 year ago

I can take a look at those suggestions