Steaf23
commented
1 year ago Hey, I dont know if you came across it, but this was the original purpose of the RecoveryData class, but since then I changed a lot of stuff so I deprecated it and never got around to working on it again. That said, this is a pretty serious pull request with a lot of changes so I will need to do a proper review, I have glanced over most of it and I feel like your approach is very thorough with all the serialization, but it does not need to be as such. for example, there is actually little difference between all card types so having separate classes does not win you that much data.
Not sure this is a feature you want to add or that is how you would approach it but I needed to add this for my own version of the plugin since my server crashes when too many people are flying around at once.
Tried my best to limit changes to existing code to ensure it could not break things already working.
I have not tested it enough to be confident it handles all scenarios.
Totally ok if you don't want to merge this into your repo. I will keep it on my personal branch and continue to use it either way so all good!