Steaf23
commented
1 year ago the reason for the team manager adding player names to the teams was for the scoreboard prefixes. it seems the teams in BingoTeam are only used for bookkeeping. I will replace adding player ids by the display names so we keep the prefixes and remove it from the TeamManager to make it more consistent (and to not leak memory...)
Team entries seem to be based on player name and not id so removing the player from a team was not working when switching to automatic.
Currently we add both the id and the player name to entries not sure if there is a reason to add the id but to avoid breaking anything in case there is something I don't understand I simply started removing both when removing a player as well.
Fairly sure we could remove the id from removing and adding member in BingoTeam.java and make it name based