Steaf23 / BingoReloaded

Minecraft Bingo 1.18+ Plug-In
GNU General Public License v3.0
23 stars 10 forks source link

Add toggle for deleting task items #31

Closed tronfy closed 1 year ago

tronfy commented 1 year ago

When completing an ItemTask, the items in question get removed from the player's inventory. This PR adds a toggle to ExtraBingoMenu that controls whether that happens or not.

This is marked as a draft because:

Steaf23 commented 1 year ago

I think this feature would work better as a config option, not a game setting, as I don't see why you would want this to be different between games

Steaf23 commented 1 year ago

And the way you would theoretically implement the serialization is check if the variable exists, and if doesnt, use a default value.

tronfy commented 1 year ago

I think this feature would work better as a config option, not a game setting, as I don't see why you would want this to be different between games

Fair point! Just reworked it as a config option.