search

Steaf23 / BingoReloaded

Minecraft Bingo 1.18+ Plug-In
GNU General Public License v3.0
23 stars 10 forks source link

Advancement Tasks no longer work on 1.20.2 #33

Closed chrisjanusa closed 10 months ago

chrisjanusa commented 10 months ago

Advancement tasks no longer work on 1.20.2 for some reason. I was able to fix this on my own branch by just changing line 303 of BingoCard from if (data.advancement().equals(event.getAdvancement())) { to if (data.advancement().getKey().equals(event.getAdvancement().getKey())) {

Not sure why this all of a sudden broke in 1.20.2 nor have I tested this on lower versions

Steaf23 commented 10 months ago

I have gotten compaints from users about this too, thanks for finding the issue. Spigot probably messed something up with the recent updates breaking comparisons of advancement objects, using the key seems like a good solution. I will make a patch release later today

Steaf23 commented 10 months ago

Fixed in Version 2.0.1 (see https://github.com/Steaf23/BingoReloaded/releases/tag/v2.0.1)