StealthChesnut / HA-FoxESS-Modbus

Home Assistant Modbus Integration setup for Fox ESS H1 and AC Inverters
77 stars 37 forks source link

Prototype layout for repo #102

Open rand12345 opened 1 year ago

rand12345 commented 1 year ago

I noticed that you are integrating H3 inverters into the repo. Having seen this form of integration before with other platforms I'm offering a suggestion for a new layout which should help the maintainer's sanity when propagating changes. This isn't a PR although you are welcome to take it.

Pros:

Cons:

https://github.com/rand12345/HA-FoxESS-Modbus/tree/new-layout-prototype

Ndrinta commented 1 year ago

Up for you. I remember finding extremely confusing to have to use the "USB" version to then edit it to change it use he USR even thought that's on LAN so why wouldn't I use the "LAN" one? After reading the documentation then started to make sense but I never accepted the naming convention... I thought, wouldn't be better to have the "USB" version renamed to "RS485" and then you choose between USB or LAN? I initially believe would be better to have a 3 versions: a pure LAN one and 2 flavours of RS485 (RS485 -USB and RS485-LAN). Agreed, this would still be a little confusing but at least you can just copy and paste the code from git without making changes at every update but then I saw this and I believe your solution is far better.

williamjeccles commented 1 year ago

I'm discussing with Chris about adding this as a user setting so you can simply install this integration via Hacs, during the install we ask you to select your inverter model and connection method, provide an IP address and bingo it's now working and future updates can be auto-applied.