search

SteamDatabase / BrowserExtension

💻 SteamDB's extension for Steam websites
https://steamdb.info/extension/
BSD 3-Clause "New" or "Revised" License
762 stars 55 forks source link

Add supports for multiple `for_item` parameter for trade offer #108

Closed aoisensi closed 2 years ago

aoisensi commented 2 years ago

I didn't much test but working for me on Vivaldi.

xPaw commented 2 years ago

Does this match how other (if any) extensions or sites that support this param?

aoisensi commented 2 years ago

I haven't seen any other third party tool support multiple parameters. This is a modification I added because I needed it.

For reference, this user script informs multiple items separated by semicolons. (However, this script would be different because it uses them as a parameter and only supports trading cards.)

xPaw commented 2 years ago

Can you add a little documentation in readme with examples? That certainly would help with adoption.

aoisensi commented 2 years ago

Sorry. I don't want this, because I don't have good English... It works like this https://steamcommunity.com/tradeoffer/new/?partner=xxxxxxxxx&token=xxxxxxx&for_item=440_2_xxxxxxxxxx&for_item=440_2_xxxxxxxxxx

xPaw commented 2 years ago

I'll finish up this PR.

aoisensi commented 2 years ago

Thank you!

xPaw commented 2 years ago

https://github.com/SteamDatabase/BrowserExtension/compare/7fd4f07bca8cff0d1099b34857ae42dbb691889e...bb414bc2febb6542deec9cd53b2d74392b79968a