Gifts have a "View on Steam Database" button that is always greyed out

SteamDatabase / BrowserExtension

💻 SteamDB's extension for Steam websites

https://steamdb.info/extension/

BSD 3-Clause "New" or "Revised" License

802 stars 59 forks source link

Gifts have a "View on Steam Database" button that is always greyed out #15

Closed KarlCastle closed 6 years ago

KarlCastle commented 6 years ago

The button is created disabled and the segment of code that is intended to enable it has a bug that stops it from completing:

/gifts/undefined/validateunpack Failed to load resource: the server responded with a status of 404 (Not Found) inventory.js:316

I'm guessing the structure of the asset/item from CInventory changed so item.description.id is now item.assetid and PopulateActions in inventory.js hasn't been updated?

xPaw commented 6 years ago

Do you want to make a PR fixing this?

KarlCastle commented 6 years ago

Yes, I'm new to Git so I think I've clicked all the right buttons. Loading as an unpacked extension this PR has the button enable and when clicked takes me to the correct page.