SteamDatabase / BrowserExtension

💻 SteamDB's extension for Steam websites
https://steamdb.info/extension/
BSD 3-Clause "New" or "Revised" License
749 stars 57 forks source link

Games with old achievements layout breaks the new achievements script #180

Closed Californ1a closed 3 weeks ago

Californ1a commented 3 weeks ago

Describe the bug

https://github.com/SteamDatabase/BrowserExtension/blob/43ab01d0d749558690c8f67cfe2b639c77fc73db/scripts/community/achievements.js#L34

This selector doesn't exist if the page uses the old layout for achievements, like this one: https://steamcommunity.com/id/Californ1a/stats/PuzzleAgent2/?tab=achievements

Not sure how many other games still use this layout; this is the only one I've come across. It might not even be worth the effort to fix if it's only a couple games affected.

Browser name and version

Chrome latest

xPaw commented 3 weeks ago

It's not broken, it's being skipped. All these games have different layouts to I didn't want to support.

Oh right it's failing on game logo, but it won't work on achievement rows anyway.