search

SteamDatabase / BrowserExtension

💻 SteamDB's extension for Steam websites
https://steamdb.info/extension/
BSD 3-Clause "New" or "Revised" License
785 stars 59 forks source link

Update #181

Closed Justman100 closed 3 months ago

xPaw commented 3 months ago

The eslint config doesn't support new major eslint version yet, I'll update the deps later.

Justman100 commented 3 months ago

The eslint config doesn't support new major eslint version yet, I'll update the deps later.

And why are you closing the PR now?

xPaw commented 3 months ago

The ^ versions don't need bumping as there is no lock file in the repo.

Justman100 commented 3 months ago

The ^ versions don't need bumping as there is no lock file in the repo.

And? You could have simply merged with just one or two clicks! Would that really have hurt so much? Instead of destroying the work of others...

xPaw commented 3 months ago

You blindly and unnecessary bumped all the versions, eslint-config-standard currently does not support eslint 9.

https://docs.npmjs.com/about-semantic-versioning#using-semantic-versioning-to-specify-update-types-your-package-can-accept

Justman100 commented 3 months ago

You blindly and unnecessary bumped all the versions, eslint-config-standard currently does not support eslint 9.

https://docs.npmjs.com/about-semantic-versioning#using-semantic-versioning-to-specify-update-types-your-package-can-accept

Then I could just reset the part?