search

SteamDatabase / BrowserExtension

šŸ’» SteamDB's extension for Steam websites
https://steamdb.info/extension/
BSD 3-Clause "New" or "Revised" License
762 stars 55 forks source link

Does not work with Firefox Multi-account containers #56

Open engineerwolf opened 4 years ago

engineerwolf commented 4 years ago

Firefox Multi-Account Containers extension separates website storage into tab-specific Containers. I am using to keep my browsing patterns separate.

While "Sign in Via Steam" feature of Steam Database extension works inside containerized tab. The browser extension is unable to retrieve game data. Since the browser extension uses cookies stored outside the containers.

Expected behavior: The extension should use some other method to authenticate with steam. Maybe a login page for the extension itself.

xPaw commented 4 years ago

I don't think our extension can affect this.

Either whitelist it (or the domains) if possible, or raise an issue to Firefox devs.

Freso commented 8 months ago

Is this something that still isnā€™t possible to do?

Iā€™ve allowed all requested to domains, not sure what kind of allowā€listing is suggested in the Jan 22 comment. image

The website and extension also seem to be able to communicate to some degree at least, since the site tells me the extension is working: image

xPaw commented 8 months ago

Yes it's still not possible as far as I know, the extension itself doesn't run in the container, thus any requests don't have your session cookies.

If someone think it's possible to fix, PRs are welcome.

clst commented 8 months ago

You can actually open extension pages in a container. Any moz-extension:// url can be opened in a container. I don't think that'll help much for the SteamDB extension since it doesn't even have a page that displays in a tab and it probably won't solve the cookie problem.

clst commented 8 months ago

I just did a little test and I managed to open a moz-extension:// page in a tab, right click on the tab open in new container tab and I could access that container's cookies. I have no clue how to do that programmatically though. Maybe it helps.

anka-213 commented 1 month ago

Here is the official documentation for the API for Firefox Containers: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Work_with_contextual_identities

I don't know if there is something there that would easily allow solving this issue. But I found this forum post that suggested a possible workaround, with this pull request on a different extension implementing it.