search

SteamDeckHomebrew / decky-frontend-lib

The support library for creating plugins for decky
https://deckbrew.xyz
GNU Lesser General Public License v2.1
67 stars 33 forks source link

fix(ReorderableList): avoid mutating props #109

Closed RedHatter closed 5 months ago

RedHatter commented 5 months ago

The native Array.prototype.sort used in ReorderableList sorts in place resulting in the props being mutated. This PR copies the array before call sort.

I experienced some odd behavior where the list order was unstable while reordering however it has proven difficult to reproduce. I don't know for sure but this issue seems like a likely culprit. This is a good change either way.

github-actions[bot] commented 5 months ago

:tada: This PR is included in version 4.1.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: