search

SteamDeckHomebrew / decky-frontend-lib

The support library for creating plugins for decky
https://deckbrew.xyz
GNU Lesser General Public License v2.1
67 stars 33 forks source link

Added some of the SteamClient types #38

Closed Tormak9970 closed 2 years ago

FrogTheFrog commented 2 years ago

@Tormak9970 this comment is a little bit incorrect unAppID: number; // seems to be 0 for shortcuts :/. Currently there is a bug in gamescope/steamclient where it does not properly assign the app id to the process (it tries to, but fails). As a result the app id remains 0.

I think it should be changed to // currently it is always 0 for shortcuts, due to a bug in gamescope/steamclient

AAGaming00 commented 2 years ago

It's a bug in steam, not gamescope Please link this in the comment

Also please convert any important comments to JSDoc (/**) format so they show up in the docs on the wiki.

Tormak9970 commented 2 years ago

Changed it to a JSDoc prop comment and declared the global

JohnnyCrazy commented 2 years ago

I think besides the missing newline, we would be good to go @AAGaming00 ?

TrainDoctor commented 2 years ago

@AAGaming00 Please review.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 3.7.13 :tada:

The release is available on:

Your semantic-release bot :package::rocket: