SteamDeckHomebrew / decky-frontend-lib

The support library for creating plugins for decky
https://deckbrew.xyz
GNU Lesser General Public License v2.1
67 stars 34 forks source link

feat(deck-components): add standalone slider component #96

Closed jessebofill closed 7 months ago

jessebofill commented 1 year ago

This is just the built in slider component. Note that this component does not give any indication of when it's focused, as that's normally indicated by the field.

beebls commented 1 year ago

Code all looks good, do you have a plugin that uses this so we can test?

AAGaming00 commented 1 year ago

are you sure this isn't just a property of CommonUIModule?

jessebofill commented 1 year ago

Code all looks good, do you have a plugin that uses this so we can test?

No, I don't. I just found it yesterday per AA's request.

are you sure this isn't just a property of CommonUIModule?

Ah indeed you are correct. I'll change that. Is there a reason why the other components are still found by toString'ing as opposed to just using the property name?

AAGaming00 commented 1 year ago

Ah indeed you are correct. I'll change that. Is there a reason why the other components are still found by toString'ing as opposed to just using the property name?

iirc that's only the ones that are outside commonui

also commonui didn't have names at all until like June, so some of the old code works that way, we should probably refactor that soon