SteamDeckHomebrew / decky-loader

A plugin loader for the Steam Deck.
https://decky.xyz
GNU General Public License v2.0
4.49k stars 156 forks source link

SettingsManager puts json in ~/homebrew and not ~/homebrew/settings #246

Closed KP2048 closed 1 year ago

KP2048 commented 1 year ago

here: https://github.com/SteamDeckHomebrew/decky-loader/blob/db7bb236d87fab6163612a61ae62a4e5389d92cd/backend/settings.py#L13 you are not including "/settings" in the json path, so it puts it in the ~/homebrew directory. i would assume settings go in settings directory, right?

TrainDoctor commented 1 year ago

Note: Considerations for backwards compat needed, some plugins already exist that assume incorrect placement of output json and will need to be accommodated.

KP2048 commented 1 year ago

they would have to hand that i believe. i have 2 plugins that do this, but since they go through settings manager, the json would just have to be moved. you could just have settings manager move all jsons into settings/

TrainDoctor commented 1 year ago

Resolved in aec7063