SteamDeckHomebrew / decky-loader

A plugin loader for the Steam Deck.
https://decky.xyz
GNU General Public License v2.0
4.78k stars 166 forks source link

[BUG] Plugins disappeared after updating until reboot #332

Closed KrisCris closed 1 year ago

KrisCris commented 1 year ago

Please confirm

Bug Report Description

After plugin updates, some of them disappeared from the installed list and the quick access panel, not even showing up after reinstalling, until I rebooted the system.

I can't recall which of them were missing, but IIRC the audio loader is definitely one of them.

Expected Behaviour

All the plugins should show up.

SteamOS version

3.4.4

Selected Update Channel

Prerelease

Have you modified the read-only filesystem at any point?

NO

Logs

deckylog.txt

TrainDoctor commented 1 year ago

Please try to replicate the issue and try to determine what plugins are being not loaded, this will help us to narrow down the issue.

KrisCris commented 1 year ago

Is there a way to downgrade a plugin? Otherwise, it might be tricky to reproduce the issue until some plugins release updates...

TrainDoctor commented 1 year ago

Is there a way to downgrade a plugin? Otherwise, it might be tricky to reproduce the issue until some plugins release updates...

Copied from my tag to you on discord. image

KrisCris commented 1 year ago

So, I downgraded the following plugins:

  1. VibrantDeck,
  2. Audio Loader,
  3. Memory Deck,
  4. MoonDeck

then upgraded them in the same order, and all of them disappeared.

TrainDoctor commented 1 year ago

So, I downgraded the following plugins:

...

then upgraded them in the same order, and all of them disappeared.

journalctl -b0 -u plugin_loader.service > log.txt to grab the logs from when you downgraded and upgraded please.

KrisCris commented 1 year ago

deckylog.txt

The log is a bit messy, I initially downgraded plugins without uninstalling them and upgraded, but failed to reproduce the issue. So I uninstalled them, installed older versions, then upgraded them, and the issue appeared.

However, when I tried to reproduce it again (since I want to get a clean dump of the log), tried a couple of times but couldn't reproduce it anymore :/

OdinVex commented 1 year ago

A quick glance at a friend's filesystem shows the PluginLoader script being overwritten with 9 bytes Not Found. Thinking some checks need to be added to update-routine (they attempted to update, it just sat at 'Updating', reboot and gone). (Or is that file not used for what I'm thinking off-hand?)

equilibri0 commented 1 year ago

same issue, updating to a new steamOS beta and updated the deckyloader, it disappears.

TrainDoctor commented 1 year ago

same issue, updating to a new steamOS beta and updated the deckyloader, it disappears.

Please provide logs. This information ia useless without logs.

OdinVex commented 1 year ago

same issue, updating to a new steamOS beta and updated the deckyloader, it disappears.

Please provide logs. This information ia useless without logs.

Not really. 'Not Found' in the PluginLoader file was rather helpful (suggestive of a network-related issue during an update, my guess, with contents overwritten with garbage.) Perhaps your Decky Loader should use a two-stage loader. Perhaps a first-stage loader that heals a second-stage 'actual software' of Decky Loader.

TrainDoctor commented 1 year ago

Not really. 'Not Found' in the PluginLoader file was rather helpful (suggestive of a network-related issue during an update, my guess, with contents overwritten with garbage.) Perhaps your Decky Loader should use a two-stage loader. Perhaps a first-stage loader that heals a second-stage 'actual software' of Decky Loader.

If you'd like to see a feature added to decky loader, you're always welcome to submit a pull request. Thanks.

OdinVex commented 1 year ago

If you'd like to see a feature added to decky loader, you're always welcome to submit a pull request. Thanks.

I have no interest in developing Decky Loader, submitted this on behalf of a friend who is illiterate when it comes to computers. They want this loader, I don't know why. Merely offered that suggestion of a two-stage self-healing loader setup to prevent these kinds of issues in the first place. I do my own thing with my Steam Deck. Well wishes.

geeksville commented 1 year ago

i think this actually might be a dup of #390 (I didn't find this one originally when I was looking)

TrainDoctor commented 1 year ago

This has been fixed since #391 was merged. Please let us know if this fix did not work for you.