SteamDeckHomebrew / decky-loader

A plugin loader for the Steam Deck.
https://decky.xyz
GNU General Public License v2.0
4.58k stars 158 forks source link

[Request] Identify and index plugins by package name, not plugin name #571

Open wheaney opened 9 months ago

wheaney commented 9 months ago

Please confirm

Feature Request Description

I recently tried to "rebrand" my plugin by changing its name (as defined in plugin.json's name property) and it created a duplicate plugin in the store. It's been a couple months since I tested this, so I'm not 100% certain anymore, but I think it also would prevent decky from detecting that there's an update for an installed plugin, because it would treat it as a new plugin. In contrast to this, the installation process creates a plugin directory based on the package name (or repo name, not sure which), so I believe it wouldn't install as a second plugin because it would overwrite the old one. This package name should be used to uniquely identify the plugin throughout the whole stack, allowing devs to rename a plugin and still get a smooth update experience for existing users.

Further Description

No response

TrainDoctor commented 2 weeks ago

I don't disagree with the logic, but I don't think we have a good way to get such a change integrated into our CI, onto the server etc. If someone wishes to PR this we'd be happy to review and hopefully accept it but for now the technical debt has us not moving on this one.