SteamDeckHomebrew / decky-loader

A plugin loader for the Steam Deck.
https://decky.xyz
GNU General Public License v2.0
4.25k stars 154 forks source link

[BUG] Decky is broken on latest beta client. #597

Closed PartyWumpus closed 3 months ago

PartyWumpus commented 3 months ago

Please confirm

Bug Report Description

Opening the decky tab shows a screen wide error. "TypeError: Cannot read properties of undefined (reading 'Title')". The line with the error is return (window.SP_REACT.createElement(Focusable, { style: titleStyles, className: staticClasses.Title },. Something is up with the staticClasses, they appear to not be defined. I don't have time to look further into it right now.

Also the toaster might be broken again. Not 100% sure.

SteamOS version

Client version 1709920887 (mar 7)

Selected Update Channel

Prerelease

Have you modified the read-only filesystem at any point?

No response

Backend Logs

not relevant

Frontend Logs

not relevant

sickhate commented 3 months ago

Even on stable steam os is broken

Zodiaksl commented 3 months ago

Can confirm.

Also on latest BETA. Tried going back to Stable, pre-release, uninstalling, reinsitalling, etc.

Lordmau5 commented 3 months ago

Adding onto this, one of the plug-ins I have installed (I assume a theme) is preventing me from opening a view of a game

Error Reference: Shared SteamUI_8751946_f71b1e5c8d53b3f1

Cannot read properties of undefined (reading 'InnerContainer')
PartyWumpus commented 3 months ago

The problem has been found, valve has renamed most of the CSS classes in the entire UI. Shouldn't be too hard to work around.

spamsgood commented 3 months ago

It's also broken preview. It's so broken for me I can't even launch games because when i select any game this is what I get. image

ShadowMonster99 commented 3 months ago

upvote this forum post: https://steamcommunity.com/groups/SteamClientBeta/discussions/3/4298194722189670859/

Steam is making changes that will affect mods like this.

AndehX commented 3 months ago

any idea how long this will take to fix?

zcoop98 commented 3 months ago

upvote this forum post:

https://steamcommunity.com/groups/SteamClientBeta/discussions/3/4298194722189670859/

Steam is making changes that will affect mods like this.

Looks like staff replied to that thread (emphasis mine):

toms 13 hours ago
I want to clarify an aspect of what has changed: classes are not being randomized every update. These classes have all changed in the most recent beta update, because of the changes to classname generation, but there are not currently any plans to change them all again in future updates. Of course, there is no guarantee that any given class will remain the same between updates, but this has always been the case.

Just sorta a fact of life with community projects that hook into UI; hopefully what they say holds true and classname changes won't need to be a common occurrence in the future.

sickhate commented 3 months ago

I cant wait for this to be fixed. These plugins are awesome

PartyWumpus commented 3 months ago

For now I'd just switch to the stable client.

PartyWumpus commented 3 months ago

Commit https://github.com/SteamDeckHomebrew/decky-loader/commit/4a7e9a5f3dc8fa1ab4789ac8396b030d72e1facc should fix this. Try updating to the newest prerelease.

Zodiaksl commented 3 months ago

Commit 4a7e9a5 should fix this. Try updating to the newest prerelease.

How does one download this in Desktop mode?

PartyWumpus commented 3 months ago

How does one download this in Desktop mode?

Rerun the installer script and select "update to the latest prerelease", can be downloaded from the big download button on this repo's readme page

Zodiaksl commented 3 months ago

Still on latest SteamOS Beta Channel, Updated to v2.12.0-pre1

Decky is now accessible from Game mode. However, I get errors for every single plugin trying to load.

d3m3vilurr commented 3 months ago

Still on latest SteamOS Beta Channel, Updated to v2.12.0-pre1

Decky is now accessible from Game mode. However, I get errors for every single plugin trying to load.

plugins also have to update DFL to 3.25

sickhate commented 3 months ago

Yeah still some broken here on beta as well

TiZ-HugLife commented 3 months ago

Still some broken here? More like most, for me. ControllerTools, Shotty, ProtonDB Badges, SteamGridDB, and more very useful plugins are now broken, and their maintainers have to be the ones to perform updates in order to not be broken? Can Decky do anything to future-proof against this sort of thing?

TrainDoctor commented 3 months ago

Still some broken here? More like most, for me. ControllerTools, Shotty, ProtonDB Badges, SteamGridDB, and more very useful plugins are now broken, and their maintainers have to be the ones to perform updates in order to not be broken? Can Decky do anything to future-proof against this sort of thing?

We already have in terms of frontends, it's called global DFL. Plugin authors can reference the current plugin template.