SteamDeckHomebrew / decky-loader

A plugin loader for the Steam Deck.

https://decky.xyz

GNU General Public License v2.0

4.25k stars 154 forks source link

[Feature] Warn users on possible risks on installing third party unvetted plugins #600

Open RodoMa92 opened 3 months ago

RodoMa92 commented 3 months ago

Please tick as appropriate:

[ ] I have tested this code on a steam deck or on a PC
[x] My changes generate no new errors/warnings
[ ] This is a bugfix/hotfix
[x] This is a new feature

Description

This PR implements proper warning messages for third party install outside our store to warn users of potential malicious code outside our ecosystem.

RodoMa92 commented 3 months ago

Nice, LGTM!

I think the TranslationHelper might be doing too much tho and grow into oblivion, maybe separate functions/helpers in the components would be better in the long term.

Yeah, I agree, I just need to find a decent place to place them without adding too much clutter in the structure of the project. I'll probably do this not too far down the line.