SteamDeckHomebrew / decky-loader

A plugin loader for the Steam Deck.
https://decky.xyz
GNU General Public License v2.0
4.75k stars 166 forks source link

[BUG] Already installed plugins fail to load if GitHub is experiencing issues #686

Open milroneth opened 3 months ago

milroneth commented 3 months ago

Please confirm

Bug Report Description

This one is weird, I promise. Also, I have no logs unfortunately and cannot currently reproduce, so not 100% confident.

During today's GitHub outage I was doing testing for #683, restarting the Decky loader service multiple times. I was on v3.0.0-pre10 on Steam Beta.

I did not notice the GitHub issues until I tried changing Decky channel to some testing version or even stable just to trigger a Decky reload, when it was unable to find any version at all. Since my network was ok, I thought it peculiar, but I just restarted my Deck completely to clean up the environment. I was still unaware of GitHub being down.

Upon boot, Decky failed to load multiple of my plugins, which made me believe I had broken something, tried "updating" to stable again, nothing would load, restarted again, same issue. I booted to the Desktop once in the mid of this and unless I'm confused, when I opened big picture the plugins did load ok! Could this be because they get loaded later? I then rebooted, only for them to fail again.

20240815024905_1

At that point I noticed the GitHub issues, imagined it might be relevant, rebooted with WiFi off and everything was ok, rebooted again with WiFi on and plugins broke again. And at my next reboot GitHub was semi-fine again and couldn't have this happen again, plugins worked normally.

I tried sending github.com, githubusercontent.com, and raw.githubusercontent.com to 1.1.1.1 through my local DNS, but since that only resulted in certificate errors, it wouldn't trigger the problem either, we need GitHub to be half-broken for this (give an actual answer, that just is not what was expected.)

I will repeat, I might be off here since this is all unverifiable. But unless that "Failed to fetch" error means something specific that points to another direction, I'm pretty sure I got this right. Or it's late and I've done more testing than I could handle...

Expected Behaviour

Decky Loader shouldn't be unable to properly load plugins because of GitHub issues?

SteamOS version

SteamOS Beta 3.6

Selected Update Channel

Prerelease

Have you modified the read-only filesystem at any point?

No

Backend Logs

--

Frontend Logs

--

Jaynator495 commented 2 months ago

Alright, so as requested, I'm putting all the information I know here. It seems to happen about 1/3rd of the time I start my deck, and can be replicated for me by just restarting the decky loader service a few times.

I have an LE 1tb, SteamOS Preview 3.6.11 Decky Loader 3.0.0-pre12

All installed plugins and versions:

Directory: ./Bluetooth/
Package Name: Bluetooth
Version: 2.3.0
-----------------------------
Directory: ./decky-brightness-bar/
Package Name: decky-brightness-bar
Version: 1.0.2
-----------------------------
Directory: ./decky-dictation/
Package Name: decky-dictation
Version: 1.1.0-d8ec453
-----------------------------
Directory: ./decky-steamgriddb/
Package Name: decky-steamgriddb
Version: 1.5.1-loaderv2-1f13f72
-----------------------------
Directory: ./decky-terminal/
Package Name: decky-terminal
Version: 0.4.1
-----------------------------
Directory: ./decky-wine-cellar/
Package Name: decky-wine-cellar
Version: 0.1.5
-----------------------------
Directory: ./Emuchievements/
Package Name: emuchievements
Version: 2.0.3
-----------------------------
Directory: ./EmuDecky/
Package Name: emudecky
Version: 1.0.7
-----------------------------
Directory: ./Fantastic/
Package Name: Fantastic
Version: 0.5.1
-----------------------------
Directory: ./hltb-for-deck/
Package Name: hltb-for-deck
Version: 1.5.0-9edd235
-----------------------------
Directory: ./isthereanydeal-for-deck/
Package Name: is-there-any-deal-for-deck
Version: 1.0.1
-----------------------------
Directory: ./Junk-Store/
Package Name: Junk-Store
Version: 1.1.8-fb9f702
-----------------------------
Directory: ./MagicBlackDecky/
Package Name: magicblack-decky
Version: 1.0.2-584ccf4
-----------------------------
Directory: ./PowerTools/
Package Name: PowerTools
Version: 2.0.3
-----------------------------
Directory: ./protondb-decky/
Package Name: protondb-decky
Version: 1.1.0-dbec43e
-----------------------------
Directory: ./reshadeck/
Package Name: reshadeck
Version: 0.2.0
-----------------------------
Directory: ./SDH-AnimationChanger/
Package Name: decky-animation-changer
Version: 1.3.1
-----------------------------
Directory: ./SDH-AudioLoader/
Package Name: SDH-AudioLoader
Version: 1.5.1-1
-----------------------------
Directory: ./SDH-CssLoader/
Package Name: SDH-CssLoader
Version: 2.1.2
-----------------------------
Directory: ./SDH-GameThemeMusic/
Package Name: sdh-gamethememusic
Version: 1.6.0-6da9b52
-----------------------------
Directory: ./SDH-PlayTime/
Package Name: PlayTime
Version: 1.0.0-1
-----------------------------
Directory: ./Steamback/
Package Name: steamback
Version: 1.1.2-8382c7b
-----------------------------
Directory: ./steam-deck-battery-tracker/
Package Name: steam-deck-battery-tracker
Version: 0.2.0
-----------------------------
Directory: ./TabMaster/
Package Name: tabmaster
Version: 2.7.0-ff7ed08
-----------------------------
Directory: ./volume-boost/
Package Name: volume-boost
Version: 0.0.6
-----------------------------
Directory: ./VolumeMixer-decky/
Package Name: VolumeMixer-decky
Version: 1.2.1-1
-----------------------------

Steps:

  1. Boot steam deck
  2. 30% of the time you will just get a bunch of notifications for (seemingly) random plugins that failed to start