ebenbruyns commented 3 months ago

Junk-Store

This PR fixes some broken paths for the EOS overlay. very minor updates at the moment, might change depending on how long this sits in the queue

[If you have not already, please read the review and testing page on the wiki. Remove this line before submitting your plugin.]

Checklist:

Developer Checklist

[x] I am the original author or an authorized maintainer of this plugin.
[x] I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

[x] I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
[x] I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

No: I am using a custom backend other than Python.
No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
No: I am using a custom binary that has all of it's dependencies statically linked.

Testing

[x] Tested on SteamOS Stable/Beta Update Channel.

[x] Tested on SteamOS Preview Update Channel.

ebenbruyns commented 3 months ago

Do not merge this to stable immediately, let it simmer for a while first. Just in case there's a gremlin in there, like what happened with 1.0.1.

TrainDoctor commented 2 months ago

@ebenbruyns just want to clarify if this PR is good to go?

ebenbruyns commented 2 months ago

@TrainDoctor kinda, but I'd like it to have a week at least in testing to ensure it's not going to introduce a major unforeseen issues. It's only had around 500 downloads, so I don't think enough people have tried it yet.