SteamDeckHomebrew / decky-plugin-database

Decky Plugin Database. PR your plugins to this repository to have them added to the store!
https://plugins.deckbrew.xyz
GNU Affero General Public License v3.0
202 stars 109 forks source link

Update ControllerTools to v1.2.2 #647

Closed jfernandez closed 3 months ago

jfernandez commented 4 months ago

ControllerTools

Update ControllerTools to v1.2.2 and change the submodule to point to the new repository. The alphamercury repository is no longer maintained. You can verify this by going to the old url [1] and verifying that it redirects to the new url [2].

This new version pulls in the latest dependencies and makes the plugin use the global DFL to address an error [3] in the UI after the Steam Deck client update.

[1] https://github.com/alphamercury/ControllerTools [2] https://github.com/jfernandez/ControllerTools [3] https://github.com/jfernandez/ControllerTools/issues/43

Checklist:

Developer Checklist

Plugin Checklist

Plugin Backend Checklist

Testing

Several users tested this new build in this Issue and verified it works: https://github.com/jfernandez/ControllerTools/issues/43

jfernandez commented 4 months ago

@RodoMa92 I did update the pnpm lockfile, but I used the latest pnpm (9.2): https://github.com/jfernandez/ControllerTools/commit/0be62f51c42904a1ec83867d1298f9daff92b449

Do I need to use 9.05? I assumed any of the 9.* versions should work.

Nottinghster commented 4 months ago

Any news?

RodoMa92 commented 4 months ago

@RodoMa92 I did update the pnpm lockfile, but I used the latest pnpm (9.2): jfernandez/ControllerTools@0be62f5

Do I need to use 9.05? I assumed any of the 9.* versions should work.

Sorry for the delay,

Yeah, the CI was still claiming pnpm 8.5.1 and I was confused initially, turns out I forgot to update the builder docker image with the actual updated pnpm version. I might just go and update them both again to the latest one for now, to avoid confusion.

Marco

RodoMa92 commented 4 months ago

As soon as #652 lands, this should go through fine now. Sorry again for the mistake on my part. If you want to land it sooner, tho, using a closer version to 8.5.1 should make it go through fine.

Nottinghster commented 4 months ago

As soon as #652 lands, this should go through fine now. Sorry again for the mistake on my part. If you want to land it sooner, tho, using a closer version to 8.5.1 should make it go through fine.

News ??

michaljuris commented 4 months ago

https://github.com/SteamDeckHomebrew/decky-plugin-database/pull/652 seems to be still waiting for the review from somebody from SteamDeckHomebrew/loader-team ...

@RodoMa92 anyway to expedite that? ;)

Nottinghster commented 4 months ago

Again problem with pnpm ???

michaljuris commented 4 months ago

Again problem with pnpm ???

Still waiting for this: https://github.com/SteamDeckHomebrew/decky-plugin-database/pull/652 But it is approved now so @RodoMa92 can merge it now.

RodoMa92 commented 3 months ago

Sadly now that I've merged #652 (Completely forgot), I can't rerun the workflow since it seems to cap it to 30 days since the initial PR. Not sure if anyone from @SteamDeckHomebrew/loader-team can help here or if it's easier just to reopen the PR itself :S

RodoMa92 commented 3 months ago

Easier to just merge and test it out this way. It is still completely broken anyway now.