search

SteamDeckHomebrew / decky-plugin-database

Decky Plugin Database. PR your plugins to this repository to have them added to the store!
https://plugins.deckbrew.xyz
GNU Affero General Public License v3.0
204 stars 110 forks source link

UpdateTunnel deck to 1.0.4 #689

Closed bkohler616 closed 3 weeks ago

bkohler616 commented 2 months ago

TunnelDeck

Checklist:

Developer Checklist

Plugin Checklist

Plugin Backend Checklist

Testing

bkohler616 commented 2 months ago

My bad on that one - he has been properly added as a contributor, and I guess I'm the "author" now. If you want me to set him back as the author I can, just lemme know.

TrainDoctor commented 2 months ago

My bad on that one - he has been properly added as a contributor, and I guess I'm the "author" now. If you want me to set him back as the author I can, just lemme know.

If Steve wishes to retake the project then we differ to the original developer within our discussion so all good atm.

AAGaming00 commented 2 months ago

small suggestion to reduce shutdown times (applies to previous versions too): you really don't need to restart networkmanager on shutdown when the openvpn extension isn't enabled in the first place

bkohler616 commented 2 months ago

small suggestion to reduce shutdown times (applies to previous versions too): you really don't need to restart networkmanager on shutdown when the openvpn extension isn't enabled in the first place

Gotcha, I'll have that done in next version.

bkohler616 commented 3 weeks ago

Hiya. Couple of things.

  1. Is my testing results sufficient to allowing this to push through? If not, may someone help me out in testing this guy please :)
  2. @AAGaming00 , you meantioned that on shutdown that I'm resetting the Network Manager on shutdown - I'm assuming you mean the _unload function is running the uninstall script? If not, then I'm a bit lost on your suggestion, as the NetworkManager is only being restarted on enable / disable of ipv6.

Here's my testing report if that's valid or not: A) No major issues. B) When accessing the plugin quick-setting without internet the list of VPN's does not show up for 20 seconds. C)

D) Yay*

AAGaming00 commented 3 weeks ago

yes it's the uninstall script

TrainDoctor commented 3 weeks ago

@bkohler616 apologies but I just realized that you were the original PR author and I didn't realize that. In future you do need another user to properly fill out the testing form in future.

bkohler616 commented 3 weeks ago

@TrainDoctor Sorry, I didn't mean to rush you on that front - my apologies. I also don't really have known people that can test for me (I kinda suck at talking :sweat_smile:)

I put up a new one, so hopefully I can get it right this time. I'll poke the community for a tester that may wanna help me out. https://github.com/SteamDeckHomebrew/decky-plugin-database/pull/712

And again, super sorry my man :(

TrainDoctor commented 3 weeks ago

@TrainDoctor Sorry, I didn't mean to rush you on that front - my apologies. I also don't really have known people that can test for me (I kinda suck at talking 😅)

I put up a new one, so hopefully I can get it right this time. I'll poke the community for a tester that may wanna help me out. #712

And again, super sorry my man :(

Nothing to apologize for though I appreciate the thought. It's on me to better review the comments in these PRs and verify that proper procedure is being followed. You even asked whether this testing report was valid in the comment lol.