SteamDeckHomebrew / decky-plugin-template

A template for quickly creating a decky plugin from scratch
https://deckbrew.xyz
Other
219 stars 107 forks source link

VSCode extractzip task has unintended results #31

Open jurassicplayer opened 1 year ago

jurassicplayer commented 1 year ago

https://github.com/SteamDeckHomebrew/decky-plugin-template/blob/5a91054ba8d10d72b7838ae3677670f05a5757d3/.vscode/tasks.json#L102

CarJem commented 1 year ago

To add on top of this... I discovered another issue causing the following issue related to this The sed command doesn't properly account for dashes when creating the folder for the destination to go into

 *  Executing task: echo '/home/deck/homebrew/plugins/SPGM WinTweaks Intergration Plugin.zip' && ssh deck@steamdeck -p 22 -i /home/carjem/.ssh/id_rsa 'echo pass | sudo -S mkdir 755 -p "$(echo "/home/deck/homebrew/plugins/SPGM WinTweaks Intergration Plugin" | sed "s| |-|")" && echo pass | sudo -S chown deck:deck "$(echo "/home/deck/homebrew/plugins/SPGM WinTweaks Intergration Plugin" | sed "s| |-|")" && echo pass | sudo -S bsdtar -xzpf "/home/deck/homebrew/plugins/SPGM WinTweaks Intergration Plugin.zip" -C "$(echo "/home/deck/homebrew/plugins/SPGM WinTweaks Intergration Plugin" | sed "s| |-|g")" --strip-components=1 --fflags ' 

/home/deck/homebrew/plugins/SPGM WinTweaks Intergration Plugin.zip
[sudo] password for deck: bsdtar: could not chdir to '/home/deck/homebrew/plugins/SPGM-WinTweaks-Intergration-Plugin'

image

TrainDoctor commented 9 months ago

@jurassicplayer I believe I have made changes that should help with your points on the extractzip-fix branch. @CarJem I'll have another commit time permitting to help with that.

TrainDoctor commented 9 months ago

To add on top of this... I discovered another issue causing the following issue related to this The sed command doesn't properly account for dashes when creating the folder for the destination to go into

 *  Executing task: echo '/home/deck/homebrew/plugins/SPGM WinTweaks Intergration Plugin.zip' && ssh deck@steamdeck -p 22 -i /home/carjem/.ssh/id_rsa 'echo pass | sudo -S mkdir 755 -p "$(echo "/home/deck/homebrew/plugins/SPGM WinTweaks Intergration Plugin" | sed "s| |-|")" && echo pass | sudo -S chown deck:deck "$(echo "/home/deck/homebrew/plugins/SPGM WinTweaks Intergration Plugin" | sed "s| |-|")" && echo pass | sudo -S bsdtar -xzpf "/home/deck/homebrew/plugins/SPGM WinTweaks Intergration Plugin.zip" -C "$(echo "/home/deck/homebrew/plugins/SPGM WinTweaks Intergration Plugin" | sed "s| |-|g")" --strip-components=1 --fflags ' 

/home/deck/homebrew/plugins/SPGM WinTweaks Intergration Plugin.zip
[sudo] password for deck: bsdtar: could not chdir to '/home/deck/homebrew/plugins/SPGM-WinTweaks-Intergration-Plugin'

For reference, no plugin should have a name with spaces in it so in future I will aim to add support for handling dashes but I'm pretty sure it's a non-issue and the issue is spaces in the plugin name.