search

SteamGridDB / steam-rom-manager

An app for managing ROMs in Steam
GNU General Public License v3.0
1.88k stars 120 forks source link

`launchOptions` not in steam launch option but at the end of target in manual mode #625

Closed swhoro closed 5 months ago

swhoro commented 9 months ago

I want a game's launch option in steam is filled by launchOptions field in manifest.json, what should I do?

I find a related issue: https://github.com/SteamGridDB/steam-rom-manager/issues/307, but I do not find append args to executable option.

HazardousBackup commented 9 months ago

I can't say for sure because I'm not familiar enough with the codebase yet but maybe config.executable.appendArgsToExecutable is supposed to be parsedConfig.appendArgsToExecutable here: https://github.com/SteamGridDB/steam-rom-manager/blob/ed718710bdc2cb14527f801b82afb8c8353efb40/src/lib/file-parser.ts#L415

Some quick and dirty testing on my part shows the change moves launchOptions in a Manual parser to the Steam Launch Options field instead of appending it to the executable and the append args to executable option, that is only available on ROM/Glob parsers, still works.

cbartondock commented 5 months ago

The issue is actually that the manual parser doesn't have a toggle for this at the moment, I think the right way to do it (in the spirit of the manual parser) is to just add a field to the JSON file that determines this behavior (whether the launchOptions appear in the target or separately in steam).

cbartondock commented 5 months ago

Screenshot 2024-04-18 120330 Will be fixed in the next update.