SteamGridDB / steam-rom-manager

The bulk game importer and artwork manager for Steam!
https://steamgriddb.github.io/steam-rom-manager/
GNU General Public License v3.0
1.91k stars 123 forks source link

[BUG] Shortcut parser non-steam games do not work with Steam overlay #685

Closed shawly closed 4 months ago

shawly commented 4 months ago

When using the shortcut parser the shortcuts are used as targets in the created non-steam games, the problem is that the Steam overlay will not work when a shortcut is used as non-steam game.

  1. Create some shortcuts for games.
  2. Scan the shortcuts with the Shortcut parser.
  3. Run the created non-steam game
  4. Try opening the ingame overlay

I expect the overlay to work but it seems to be a limitation of Steam itself. This could be fixed by parsing the shortcuts target, arguments and working directory and creating a non-steam game from these properties.

I created a powershell script which does exactly this by creating manifest.json files from the shortcuts: https://gist.github.com/shawly/f301446b5e75639f642d76c114cd9446

I can use the Manual parser to parse these manifest.json files, but I'd rather have this functionality within the Shortcut parser.

Upvote & Fund

Fund with Polar

cbartondock commented 4 months ago

You can fix this by enabling shortcut passthrough in the parser, which parses the target instead (as you suggest).

shawly commented 4 months ago

Kind of yeah, it does not put arguments into launch options however, but putting them into the target seems to work okay I guess.

cbartondock commented 4 months ago

Do you have "append args to target" enabled? If not I am pretty sure it should set the launch options.

shawly commented 4 months ago

Neither enabling nor disabling that changes the result, the args are always appended to the target path.