search

SteamGridDB / steam-rom-manager

The bulk game importer and artwork manager for Steam!
https://steamgriddb.github.io/steam-rom-manager/
GNU General Public License v3.0
1.92k stars 123 forks source link

Parsing of GOG games installed directly instead of via GOG Galaxy DB #691

Closed HazardousBackup closed 4 months ago

HazardousBackup commented 4 months ago

Change to the GOG Galaxy Parser to add option for finding games via the registry entries that are made on install instead of via the Galaxy DB.

Closes https://github.com/SteamGridDB/steam-rom-manager/issues/672

Notes: I'm not entirely happy with how it handles DLC and the structure that has created. It probably looks bad to have failed matches even if it's just because they are DLC and thus shouldn't be matched, also it's made getRegInstalled somewhat redundant.

The alternative would be reverting to the original design and returning an empty success instead of a failed.

I'd welcome any clear critiques of my code, I'm learning Typescript on the fly with this.

cbartondock commented 4 months ago

This is great! However one thing I would add is that the toggle should be hidden unless the OS is windows (currently the GOG parser only supports windows however I do plan to implement it for Mac OS as well). I'm happy to make this change if you'd like!

cbartondock commented 4 months ago

Merged into a test branch and made some changes (which you can see here). Will make its way into master and then a release soon! Thanks for the PR :)

cbartondock commented 4 months ago
Screenshot 2024-07-17 at 8 12 49 PM

Congrats on your first feature contribution 🚀 !